From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id A7868231C for ; Thu, 27 Nov 2014 18:36:38 +0100 (CET) Received: by mail-wg0-f41.google.com with SMTP id y19so7004486wgg.28 for ; Thu, 27 Nov 2014 09:36:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=6l+XqYdVkejQjgMQKr6KvTDd3PJvo2DJg1UyewEROgw=; b=g2AQkKA3dlFMUfw7EDpYzsn89qUVU9UNm0+l9gK9snUbYa0geRC7wBgBazUjcebc8X FxsainUuDVevNBgKWETH+/0JJdlrAF05dlhYbE9qFZFelGvcRPLbt9gHOlf52ySYfIy7 Oe1AyHF2/1ItEmsQXSKOX1t22tIzjo+UbVxpaUEpHNm7y9m0XJIxylAwz35DJfYwUw7t jVSmT0IbfiM6V+MCnfqG+AUFAVYgS7UyQjzK43TqkOrYhIgwCn8IcSd/KkDU5c+sub/V fLDvD5ZmwQgN6r47dnyhDi+W6WObSjyk7msIqm8y3VD7Xm8c6n+mDVpol2ANm/eHS5gN c6Ng== X-Gm-Message-State: ALoCoQkr0dMWLIUYYB6k1FsDg7D0LC/Kju8q2lFTjHY3NJxQvEdxquZyoPmWWk/hmEDn7u+tu0Qi X-Received: by 10.180.96.162 with SMTP id dt2mr53844753wib.66.1417109798475; Thu, 27 Nov 2014 09:36:38 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id nj9sm12340958wic.10.2014.11.27.09.36.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Nov 2014 09:36:37 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Thu, 27 Nov 2014 18:36:15 +0100 Message-ID: <1423715.Xz4LrI6SsO@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <4465623.YhbiPPYfmU@xps13> References: <4465623.YhbiPPYfmU@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] issue with ixgbevf speed/duplex introduced with commit 8ef32003772a14c61c70b540e41c259c482c2fb6 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Nov 2014 17:36:38 -0000 Ping? There is still no review of this patch: http://dpdk.org/dev/patchwork/patch/1079/ And there is another patch for the same issue: http://dpdk.org/dev/patchwork/patch/1224/ 2014-11-07 17:46, Thomas Monjalon: > Hi, > > Thank you for reporting and explaining the issue. > > You have already sent a bug report and a patch for this issue. > Are you sending this email to ask a review and integration of your patch? > I think it should be reviewed by an Intel developer. > > Note: it would be good to have the commit reference in the commit log > of your patch. > > PS: in such case, it's better to reply to the previous emails > > Thanks > > I'm seeing an issue with ixgbevf speed/duplex reporting that appears to have been introduced with > > commit 8ef32003772a14c61c70b540e41c259c482c2fb6 (http://www.dpdk.org/browse/dpdk/commit/lib/librte_pmd_ixgbe/ixgbe/ixgbe_vf.c?id=8ef32003772a14c61c70b540e41c259c482c2fb6) > > > > The issue I'm seeing seems to involve the following code. If I'm reading this correctly, > > one sets "mac->get_link_status = true" if the port is not OK, where "true" means that one > > still needs to get the link status. Due to the added test "if (!mac->get_link_status)", > > one branches to the early exit if mac->get_link_status is false---meaning we have already > > obtained the link status---instead of continuing with the analysis in the function body. > > > > - if (!(hw->mbx.ops.check_for_rst(hw, 0))) { > > - *link_up = false; > > - *speed = 0; > > - return -1; > > - } > > + /* If we were hit with a reset drop the link */ > > + if (!mbx->ops.check_for_rst(hw, 0) || !mbx->timeout) > > + mac->get_link_status = true; > > > > - links_reg = IXGBE_VFREAD_REG(hw, IXGBE_VFLINKS); > > + if (!mac->get_link_status) > > + goto out; > > > > When I run "testpmd" on ixgbevf ports either in the host OS or passed > > through to a virtual machine, "testpmd" reports that the ixgbevf ports > > have "speed 100 Mbps - half-duplex". With the previous code (or with > > my patch), "testpmd" reports "speed 10000 Mbps - full-duplex". > -- Thomas