From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id DE844B410 for ; Fri, 13 Feb 2015 10:23:15 +0100 (CET) Received: by mail-wg0-f49.google.com with SMTP id l18so15425497wgh.8 for ; Fri, 13 Feb 2015 01:23:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XGjfNnUn7CWTTKtUf5da+sorAZwCP1qfCmh6//4AXuA=; b=AMTr+0opfw7tpeZwm0pe88XqZcNWUKfLuv5GDrWAJ064/CY04kWPa1hCsQX/RIojFq m388IU6i5qKgDgVCfh8xNW6X0UQuTWSfn3nSk2WUkQDD1QRVsSfG5i0AbE9jiXaB88FI qQGr5nmeVGD0YyH2Y0O9BOXpqeovVoZaFah1S22bwe/+urAccvv5lVljNDha3I/7ZbIG XHKMfeOxzwAZ/g+KOjM40wgi64RePCX6QSHH+wc2CTpOGaDFB0VRpcXH1H67dOPdc//M RK9J0LYjTQD2R8E6Su18OnYnrnGKvdicoasGhsd9Ub2W/hhCIXL5b9Mu1cn86/ItgyOK gFXg== X-Gm-Message-State: ALoCoQm14kZn6eEUDwbaAV4Pyi6G1DdK5MOKrugJI8YZN2PjCclQ4Ki68vEKanZ26zJYXU0NhELr X-Received: by 10.180.198.37 with SMTP id iz5mr4625724wic.95.1423819395762; Fri, 13 Feb 2015 01:23:15 -0800 (PST) Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id a5sm2100153wib.20.2015.02.13.01.23.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Feb 2015 01:23:15 -0800 (PST) From: Olivier Matz To: dev@dpdk.org Date: Fri, 13 Feb 2015 10:22:50 +0100 Message-Id: <1423819371-24222-20-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1423819371-24222-1-git-send-email-olivier.matz@6wind.com> References: <1423041925-26956-1-git-send-email-olivier.matz@6wind.com> <1423819371-24222-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH v3 19/20] i40e: fix offloading of outer checksum for ip in ip tunnels X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 09:23:16 -0000 When offloading the checksums of ipip tunnels, m->l2_len is set to 0 as there is no tunnel or inner l2 header. Since this is a valid value remove the test. By the way, also remove the same test with l3_len because at this point, it is expected that the software provides proper values in the mbuf. It should avoid a test in dataplane processing and therefore slightly increase performance. Signed-off-by: Olivier Matz --- lib/librte_pmd_i40e/i40e_rxtx.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/lib/librte_pmd_i40e/i40e_rxtx.c b/lib/librte_pmd_i40e/i40e_rxtx.c index d2f9a97..546f4d1 100644 --- a/lib/librte_pmd_i40e/i40e_rxtx.c +++ b/lib/librte_pmd_i40e/i40e_rxtx.c @@ -471,16 +471,6 @@ i40e_txd_enable_checksum(uint64_t ol_flags, uint16_t outer_l3_len, uint32_t *cd_tunneling) { - if (!l2_len) { - PMD_DRV_LOG(DEBUG, "L2 length set to 0"); - return; - } - - if (!l3_len) { - PMD_DRV_LOG(DEBUG, "L3 length set to 0"); - return; - } - /* UDP tunneling packet TX checksum offload */ if (ol_flags & PKT_TX_OUTER_IP_CKSUM) { -- 2.1.4