From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 95D271E33 for ; Mon, 7 Nov 2016 15:23:21 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id t79so180415081wmt.0 for ; Mon, 07 Nov 2016 06:23:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=OBgaTPIjptnkwCw+VQnARnV++LJYGFDECBsRMUcu9C8=; b=lYHgsFkQijB5Qy9eGBeFIjd57BfSGGwGVeKV3gdbbN+hsFblGaHNUuvysQ5Xrb6m6e ssEjlzBN/T4o2UG3QWrZaU0NeumsrHm0yaOEhqoTmJ06isYOGu/S6RrKLigH0s74KCAm 1CVT7k+ufU7Av4FxONBENFaPV6235yFVX9Ba3Oqs6N1NQLFwMjWLEwdByoHtKteNIkbN tKCu5GFKCSHDmXPUfE0qBbwJvhYxApr94Vj0DABYCazhyxL1DVF8U9ZIye1AfpD2vrZ/ nb8xI3EVdJyUyQIrIkOwvNESDtDN+u4HrKeAzEtJ7EoN62GXkAe0ugotZPi11R9xz0A1 ejyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=OBgaTPIjptnkwCw+VQnARnV++LJYGFDECBsRMUcu9C8=; b=D1nb5iG1rTtPDzkd4gu8s9EpVkc55sI6P7sgF3S/1jWM6Tf41Hb9C994U12tVPqVOo dCmzq53s7x+hsjzx5EzIhWmu3Fj3wm4RPVaQhPlMYoawGToPv06c4vBYpJaEpGRpnJAR Hr6R57SZPzlMAmgzjrbm1Q6qaMKD5S8zLkfVr2CDcFzZCXcfxmXSohJNJ8eL0FccX24p wAslxp7Ypbmj6Ol5js77Xgw+N+iuVLcCU+kptKeeIDsu/69dU8NWsarOOCmltzHHpfvh jMIuzPdmk3Zd5kmbaQnzhJLa9QzyPn1hA+3oteuP33suiGUC9k9zPDjGNkvcxyT3BFUC dsVw== X-Gm-Message-State: ABUngvfH2C01oFX5ZLFWE5b/9oL08MsQahoZ4ftb/d4u+de1dxwhfxzmS8u0LUp76tRaYsQx X-Received: by 10.194.86.201 with SMTP id r9mr5631298wjz.5.1478528601175; Mon, 07 Nov 2016 06:23:21 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id jb2sm31265765wjb.44.2016.11.07.06.23.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 06:23:20 -0800 (PST) From: Thomas Monjalon To: Yuanhan Liu Cc: dev@dpdk.org, Tan Jianfeng , Kevin Traynor , Ilya Maximets , Kyle Larose , Maxime Coquelin Date: Mon, 07 Nov 2016 15:23:19 +0100 Message-ID: <14239573.a6YOJCMI3o@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1478338865-26126-5-git-send-email-yuanhan.liu@linux.intel.com> References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> <1478338865-26126-1-git-send-email-yuanhan.liu@linux.intel.com> <1478338865-26126-5-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH v2 04/10] net/virtio: allocate queue at init stage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 14:23:21 -0000 2016-11-05 17:40, Yuanhan Liu: > -int virtio_dev_queue_setup(struct rte_eth_dev *dev, > -=09=09=09int queue_type, > -=09=09=09uint16_t queue_idx, > -=09=09=09uint16_t vtpci_queue_idx, > -=09=09=09uint16_t nb_desc, > -=09=09=09unsigned int socket_id, > -=09=09=09void **pvq) > +static int > +virtio_init_queue(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx)= > { I've fixed an error with debug enabled: drivers/net/virtio/virtio_ethdev.c:335:57: error: =E2=80=98nb_desc=E2=80=99 undeclared (first use in this function) PMD_INIT_LOG(DEBUG, "vq_size: %u nb_desc:%u", vq_size, nb_desc); ^