DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] testpmd: initialize rx_fc_en and tx_fc_en to zero
@ 2015-02-17 15:52 Pablo de Lara
  2015-02-20 11:15 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Pablo de Lara @ 2015-02-17 15:52 UTC (permalink / raw)
  To: dev

rx_fc_en and tx_fc_en in cmd_link_flow_ctrl_set_parsed
could be used without being initialized.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 app/test-pmd/cmdline.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index b2aab40..d52ba89 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -5117,7 +5117,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,
 	struct cmd_link_flow_ctrl_set_result *res = parsed_result;
 	cmdline_parse_inst_t *cmd = data;
 	struct rte_eth_fc_conf fc_conf;
-	int rx_fc_en, tx_fc_en;
+	int rx_fc_en, tx_fc_en = 0;
 	int ret;
 
 	/*
-- 
1.7.4.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] testpmd: initialize rx_fc_en and tx_fc_en to zero
  2015-02-17 15:52 [dpdk-dev] [PATCH] testpmd: initialize rx_fc_en and tx_fc_en to zero Pablo de Lara
@ 2015-02-20 11:15 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-02-20 11:15 UTC (permalink / raw)
  To: Pablo de Lara; +Cc: dev

2015-02-17 15:52, Pablo de Lara:
> rx_fc_en and tx_fc_en in cmd_link_flow_ctrl_set_parsed
> could be used without being initialized.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-02-20 11:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-17 15:52 [dpdk-dev] [PATCH] testpmd: initialize rx_fc_en and tx_fc_en to zero Pablo de Lara
2015-02-20 11:15 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).