DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v4 3/3] eal: remove unnecessary check for primary instance
Date: Tue, 24 Feb 2015 13:30:47 +0000	[thread overview]
Message-ID: <1424784647-19367-4-git-send-email-bruce.richardson@intel.com> (raw)
In-Reply-To: <1424784647-19367-1-git-send-email-bruce.richardson@intel.com>

In pci_uio_map_resource we check that we are in a primary process
before calling pci_uio_set_bus_master. However, there is already
an earlier check which means that we are always in a primary instance
at this point in the code, so the check can be removed.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@6wind.com>
---
 lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
index c12794e..0a95376 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
@@ -304,11 +304,9 @@ pci_uio_map_resource(struct rte_pci_device *dev)
 	}
 
 	/* set bus master that is not done by uio_pci_generic */
-	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
-		if (pci_uio_set_bus_master(dev->intr_handle.uio_cfg_fd)) {
-			RTE_LOG(ERR, EAL, "Cannot set up bus mastering!\n");
-			return -1;
-		}
+	if (pci_uio_set_bus_master(dev->intr_handle.uio_cfg_fd)) {
+		RTE_LOG(ERR, EAL, "Cannot set up bus mastering!\n");
+		return -1;
 	}
 
 	/* allocate the mapping details for secondary processes*/
-- 
2.1.0

  parent reply	other threads:[~2015-02-24 13:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22  5:30 [dpdk-dev] Testpmd returns error Tetsuya Mukawa
2015-02-22 14:17 ` Thomas Monjalon
2015-02-22 16:19   ` David Marchand
2015-02-22 18:51     ` Richardson, Bruce
2015-02-22 20:31       ` Bruce Richardson
2015-02-22 20:46 ` Bruce Richardson
2015-02-23  2:33   ` Tetsuya Mukawa
2015-02-23 11:12     ` Bruce Richardson
2015-02-23 11:36       ` Tetsuya Mukawa
2015-02-23 14:57 ` [dpdk-dev] [PATCH] eal: mmap uio resources using resourceX files Bruce Richardson
2015-02-23 15:00   ` Bruce Richardson
2015-02-23 15:30     ` Iremonger, Bernard
2015-02-24  9:21     ` Tetsuya Mukawa
2015-02-23 17:02   ` [dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support Bruce Richardson
2015-02-23 17:02     ` [dpdk-dev] [PATCH v2 1/2] eal: mmap uio resources using resourceX files Bruce Richardson
2015-02-23 17:02     ` [dpdk-dev] [PATCH v2 2/2] eal: populate uio_maps from pci mem_resources array Bruce Richardson
2015-02-24 10:53     ` [dpdk-dev] [PATCH v2 0/2] fix and improve uio_pci_generic support Bruce Richardson
2015-02-24 11:23       ` David Marchand
2015-02-24 11:32         ` Bruce Richardson
2015-02-24 12:35           ` David Marchand
2015-02-24 12:20   ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2015-02-24 12:20     ` [dpdk-dev] [PATCH v3 1/2] eal: mmap uio resources using resourceX files Bruce Richardson
2015-02-24 12:39       ` David Marchand
2015-02-24 12:20     ` [dpdk-dev] [PATCH v3 2/2] eal: populate uio_maps from pci mem_resources array Bruce Richardson
2015-02-24 12:38       ` David Marchand
2015-02-24 13:30   ` [dpdk-dev] [PATCH v4 0/3] fix and improve uio_pci_generic support Bruce Richardson
2015-02-24 13:30     ` [dpdk-dev] [PATCH v4 1/3] eal: mmap uio resources using resourceX files Bruce Richardson
2015-02-24 13:30     ` [dpdk-dev] [PATCH v4 2/3] eal: populate uio_maps from pci mem_resources array Bruce Richardson
2015-02-24 13:30     ` Bruce Richardson [this message]
2015-02-24 21:33     ` [dpdk-dev] [PATCH v4 0/3] fix and improve uio_pci_generic support Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1424784647-19367-4-git-send-email-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).