From: Robert Sanford <rsanford2@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 3/3] timer: fix rte_timer_reset return value
Date: Tue, 24 Feb 2015 23:09:49 -0500 [thread overview]
Message-ID: <1424837389-56276-4-git-send-email-rsanford2@gmail.com> (raw)
In-Reply-To: <1422996127-64370-1-git-send-email-rsanford2@gmail.com>
- API rte_timer_reset() should return -1 when the timer is in the
RUNNING or CONFIG state. Instead, it ignores the return value of
internal function __rte_timer_reset() and always returns 0.
We change rte_timer_reset() to return the value returned by
__rte_timer_reset().
- Enhance timer stress test 2 to report how many timer reset
collisions occur, i.e., how many times rte_timer_reset() fails
due to a timer being in the CONFIG state.
Signed-off-by: Robert Sanford <rsanford2@gmail.com>
---
app/test/test_timer.c | 19 ++++++++++++++++---
lib/librte_timer/rte_timer.c | 4 +---
2 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/app/test/test_timer.c b/app/test/test_timer.c
index 070437a..79fa955 100644
--- a/app/test/test_timer.c
+++ b/app/test/test_timer.c
@@ -247,10 +247,12 @@ static int
timer_stress2_main_loop(__attribute__((unused)) void *arg)
{
static struct rte_timer *timers;
- int i;
+ int i, ret;
static volatile int ready = 0;
uint64_t delay = rte_get_timer_hz() / 4;
unsigned lcore_id = rte_lcore_id();
+ int32_t my_collisions = 0;
+ static rte_atomic32_t collisions = RTE_ATOMIC32_INIT(0);
if (lcore_id == rte_get_master_lcore()) {
cb_count = 0;
@@ -269,15 +271,25 @@ timer_stress2_main_loop(__attribute__((unused)) void *arg)
}
/* have all cores schedule all timers on master lcore */
- for (i = 0; i < NB_STRESS2_TIMERS; i++)
- rte_timer_reset(&timers[i], delay, SINGLE, rte_get_master_lcore(),
+ for (i = 0; i < NB_STRESS2_TIMERS; i++) {
+ ret = rte_timer_reset(&timers[i], delay, SINGLE, rte_get_master_lcore(),
timer_stress2_cb, NULL);
+ /* there will be collisions when multiple cores simultaneously
+ * configure the same timers */
+ if (ret != 0)
+ my_collisions++;
+ }
+ if (my_collisions != 0)
+ rte_atomic32_add(&collisions, my_collisions);
ready = 0;
rte_delay_ms(500);
/* now check that we get the right number of callbacks */
if (lcore_id == rte_get_master_lcore()) {
+ my_collisions = rte_atomic32_read(&collisions);
+ if (my_collisions != 0)
+ printf("- %d timer reset collisions (OK)\n", my_collisions);
rte_timer_manage();
if (cb_count != NB_STRESS2_TIMERS) {
printf("Test Failed\n");
@@ -317,6 +329,7 @@ timer_stress2_main_loop(__attribute__((unused)) void *arg)
rte_free(timers);
timers = NULL;
ready = 0;
+ rte_atomic32_set(&collisions, 0);
if (cb_count != NB_STRESS2_TIMERS) {
printf("Test Failed\n");
diff --git a/lib/librte_timer/rte_timer.c b/lib/librte_timer/rte_timer.c
index dae76cc..d18abf5 100644
--- a/lib/librte_timer/rte_timer.c
+++ b/lib/librte_timer/rte_timer.c
@@ -424,10 +424,8 @@ rte_timer_reset(struct rte_timer *tim, uint64_t ticks,
else
period = 0;
- __rte_timer_reset(tim, cur_time + ticks, period, tim_lcore,
+ return __rte_timer_reset(tim, cur_time + ticks, period, tim_lcore,
fct, arg, 0);
-
- return 0;
}
/* loop until rte_timer_reset() succeed */
--
1.7.1
prev parent reply other threads:[~2015-02-25 4:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 20:42 [dpdk-dev] [RFC PATCH] rte_timer: Fix " rsanford2
2015-02-06 11:10 ` Olivier MATZ
2015-02-06 17:26 ` Robert Sanford
2015-02-08 10:53 ` Olivier MATZ
2015-02-25 4:09 ` [dpdk-dev] [PATCH v2 0/3] timer: fix rte_timer_reset Robert Sanford
2015-02-25 8:58 ` Olivier MATZ
2015-02-25 9:46 ` Thomas Monjalon
2015-02-25 11:02 ` Robert Sanford
2015-02-25 11:09 ` Thomas Monjalon
2015-02-25 11:16 ` Bruce Richardson
2015-02-25 13:34 ` Robert Sanford
2015-02-25 4:09 ` [dpdk-dev] [PATCH v2 1/3] timer: pause in rte_timer_reset_sync Robert Sanford
2015-02-25 4:09 ` [dpdk-dev] [PATCH v2 2/3] timer: fix stress test on multiple runs Robert Sanford
2015-02-25 4:09 ` Robert Sanford [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1424837389-56276-4-git-send-email-rsanford2@gmail.com \
--to=rsanford2@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).