From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f170.google.com (mail-ie0-f170.google.com [209.85.223.170]) by dpdk.org (Postfix) with ESMTP id 43BFE5A31 for ; Thu, 26 Feb 2015 03:32:06 +0100 (CET) Received: by iecar1 with SMTP id ar1so10520179iec.0 for ; Wed, 25 Feb 2015 18:32:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=itEyE8CQPoPZlKj7HVpfO32gwifT1T1m14BwACezeJ0=; b=AK6rEOHzVtV4BFaEDZfbhmBRJXLgrYoCJ/79b1DCHgwnXCNpLX/tLehfnGfHa81RaT bAWuU2CY7Zahwn5Z+lLpsDO1PaqS6yF/UXk0ae1ddXhlMA9Zz3mtg6C+ahU7XJjwRksM sUKCe4Fe/vsP9YGd3G7kEc8PrXRAr1RDCXz72vWr/wBy/Izleaswyqxxz4LL4bNxtHV0 HNTRrCHMumbJ+13qPPJMGkbhNktngKr1j+pTcm6VLFHXjK11BqlunVv866Wskl9kpaex nbTrZaZTIIHGS0xxy85kYBx8qcPNeJ95SjEMHZzBq7w5vAMCURi8jgLcQXNcV+81eslH 9mrQ== X-Gm-Message-State: ALoCoQm+L6GlLkY28NHx5kK9QUFxJzb0XAQ/TiFdRMrrl4X4b5jHc2kGCXw5kmq0QuC4mo12xwxV X-Received: by 10.107.166.146 with SMTP id p140mr8478590ioe.61.1424917925749; Wed, 25 Feb 2015 18:32:05 -0800 (PST) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id y5sm336741ign.7.2015.02.25.18.32.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Feb 2015 18:32:04 -0800 (PST) From: Stephen Hemminger To: Yong Wang Date: Wed, 25 Feb 2015 18:31:57 -0800 Message-Id: <1424917922-1979-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1424917922-1979-1-git-send-email-stephen@networkplumber.org> References: <1424917922-1979-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH 2/7] vmxnet3: remove mtu check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 02:32:06 -0000 Remove check for packets greater than MTU. No other driver does this, it should be handled at higher layer Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 1 - lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 10 ---------- 3 files changed, 13 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c index 23b4558..570565a 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c @@ -219,7 +219,6 @@ eth_vmxnet3_dev_init(__attribute__((unused)) struct eth_driver *eth_drv, hw->num_rx_queues = 1; hw->num_tx_queues = 1; - hw->cur_mtu = ETHER_MTU; hw->bufs_per_pkt = 1; /* Check h/w version compatibility with driver. */ @@ -394,7 +393,6 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev) devRead->misc.queueDescPA = hw->queueDescPA; devRead->misc.queueDescLen = hw->queue_desc_len; - devRead->misc.mtu = hw->cur_mtu; devRead->misc.numTxQueues = hw->num_tx_queues; devRead->misc.numRxQueues = hw->num_rx_queues; diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h index e97e3ca..b392061 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h @@ -107,7 +107,6 @@ struct vmxnet3_hw { uint8_t num_tx_queues; uint8_t num_rx_queues; uint8_t bufs_per_pkt; - uint16_t cur_mtu; Vmxnet3_TxQueueDesc *tqd_start; /* start address of all tx queue desc */ Vmxnet3_RxQueueDesc *rqd_start; /* start address of all rx queue desc */ diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 5fe3de5..38ac811 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c @@ -369,16 +369,6 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, continue; } - /* Needs to minus ether header len */ - if (txm->data_len > (hw->cur_mtu + ETHER_HDR_LEN)) { - PMD_TX_LOG(DEBUG, "Packet data_len higher than MTU"); - rte_pktmbuf_free(tx_pkts[nb_tx]); - txq->stats.drop_total++; - - nb_tx++; - continue; - } - txd = (Vmxnet3_TxDesc *)(txq->cmd_ring.base + txq->cmd_ring.next2fill); if (rte_pktmbuf_pkt_len(txm) <= VMXNET3_HDR_COPY_SIZE) { struct Vmxnet3_TxDataDesc *tdd; -- 2.1.4