From: Michael Qiu <michael.qiu@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] librte_eal/common: Fix cast from pointer to integer of different size
Date: Tue, 3 Mar 2015 10:20:51 +0800 [thread overview]
Message-ID: <1425349251-15663-1-git-send-email-michael.qiu@intel.com> (raw)
In-Reply-To: <1425281223-14043-1-git-send-email-michael.qiu@intel.com>
/i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
cast from pointer to integer of different size
[-Werror=pointer-to-int-cast]
dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
Type 'long long' is 64-bit in i686 platform while 'void *'
is 32-bit.
Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
v2 --> v1:
Remove unnecessary casting (void *)
lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
index 7b2d382..85a5f4d 100644
--- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
+++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
@@ -589,12 +589,12 @@ COPY_BLOCK_64_BACK15:
* unaligned copy functions require up to 15 bytes
* backwards access.
*/
- dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
+ dstofss = 16 - (int)((long)dst & 0x0F) + 16;
n -= dstofss;
rte_mov32((uint8_t *)dst, (const uint8_t *)src);
src = (const uint8_t *)src + dstofss;
dst = (uint8_t *)dst + dstofss;
- srcofs = (int)((long long)(const void *)src & 0x0F);
+ srcofs = (int)((long)src & 0x0F);
/**
* For aligned copy
--
1.9.3
next prev parent reply other threads:[~2015-03-03 2:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 7:27 [dpdk-dev] [PATCH] " Michael Qiu
2015-03-02 11:39 ` Gonzalez Monroy, Sergio
2015-03-03 2:02 ` Qiu, Michael
2015-03-03 2:20 ` Michael Qiu [this message]
2015-03-03 8:25 ` [dpdk-dev] [PATCH v2] " Pawel Wodkowski
2015-03-03 9:59 ` Qiu, Michael
2015-03-03 13:37 ` Pawel Wodkowski
2015-03-04 1:58 ` Qiu, Michael
2015-03-04 8:18 ` Pawel Wodkowski
2015-03-04 11:24 ` Qiu, Michael
2015-03-05 7:46 ` [dpdk-dev] [PATCH v3] " Michael Qiu
2015-03-05 8:25 ` Tang, HaifengX
2015-03-06 3:13 ` [dpdk-dev] [PATCH] " Michael Qiu
2015-03-09 5:38 ` Wang, Zhihong
2015-03-09 11:43 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425349251-15663-1-git-send-email-michael.qiu@intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).