From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id A4C649A88 for ; Tue, 3 Mar 2015 16:24:41 +0100 (CET) Received: by widex7 with SMTP id ex7so23644927wid.4 for ; Tue, 03 Mar 2015 07:24:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=Riusdj4fTESGMBJIWnleNnvUam9UwlsgF44VLWNEY6U=; b=Uml8IRmBVyP+WgdjqC3pYTxgnFPqBnruPMprFjVm66KtSckL10GOrdVHtfO/U/1hIl Dht2w6f9C8Dx5FZ8rYNMD6o0aKV+QQxLJO9zuYB1wJQbet1oo5IisYISxrxVT+hFN9S2 XpRWw56Ambz+Ro3N7a9lfeNi0Ri/VuJCkMpPfbtdA6X8G9KQmeG8+01681rTXVTbsPWu L3RjGdbvzzSa44ILRJk414ZBS8dt0IMjxzY9E9dsjj0MwGlCQpFsxa1AhO4MSZGgFEyr DLKfEprKyFXzorbAOKp3FSFrZj1QFP/rFzhDW+IgQl3OU+vaBF33zR4Xo+7YVbFYvWmx raTA== X-Gm-Message-State: ALoCoQmq2Ioca10t/ot6/jyKcAOuSG/ktf2RITE5IRaPaTnzx7crQukUU3Ul0h5MMisFVqpiEqZQ X-Received: by 10.181.13.42 with SMTP id ev10mr3719743wid.69.1425396281328; Tue, 03 Mar 2015 07:24:41 -0800 (PST) Received: from localhost.localdomain (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id gf11sm2889236wic.18.2015.03.03.07.24.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 03 Mar 2015 07:24:39 -0800 (PST) From: Thomas Monjalon To: dev@dpdk.org Date: Tue, 3 Mar 2015 16:23:50 +0100 Message-Id: <1425396230-13379-8-git-send-email-thomas.monjalon@6wind.com> X-Mailer: git-send-email 2.2.2 In-Reply-To: <1425396230-13379-1-git-send-email-thomas.monjalon@6wind.com> References: <1425396230-13379-1-git-send-email-thomas.monjalon@6wind.com> Subject: [dpdk-dev] [PATCH 7/7] bond: remove debug function to fix link with shared lib X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2015 15:24:41 -0000 The function print_client_stats was used in the example without being clearly exported in the map file. So it breaks linking with shared library when debug is enabled. It's better to remove this function as it probably could be implemented with statistics API. Fixes: cc7e8ae84faa ("add example application for link bonding mode 6") Signed-off-by: Thomas Monjalon --- examples/bond/main.c | 5 ----- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 13 ------------- 2 files changed, 18 deletions(-) diff --git a/examples/bond/main.c b/examples/bond/main.c index e4457f2..7da6bfc 100644 --- a/examples/bond/main.c +++ b/examples/bond/main.c @@ -650,7 +650,6 @@ cmdline_parse_inst_t cmd_quit = { }, }; -extern void print_client_stats(void); struct cmd_show_result { cmdline_fixed_string_t show; }; @@ -680,10 +679,6 @@ static void cmd_show_parsed(__attribute__((unused)) void *parsed_result, global_flag_stru_p->port_packets[1], global_flag_stru_p->port_packets[2]); rte_spinlock_unlock(&global_flag_stru_p->lock); - -#if defined(RTE_LIBRTE_BOND_DEBUG_ALB_L1) || defined(RTE_LIBRTE_BOND_DEBUG_ALB) - print_client_stats(); -#endif } cmdline_parse_token_string_t cmd_show_show = diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index 7dee5f2..af8113e 100644 --- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c +++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c @@ -279,19 +279,6 @@ update_client_stats(uint32_t addr, uint8_t port, uint32_t *TXorRXindicator) } -void print_client_stats(void); -void print_client_stats(void) -{ - int i = 0; - char buf[MaxIPv4String]; - - for (; i < active_clients; i++) { - ipv4_addr_to_dot(client_stats[i].ipv4_addr, buf, MaxIPv4String); - printf("port:%d client:%s RX:%d TX:%d\n", client_stats[i].port, buf, - client_stats[i].ipv4_rx_packets, - client_stats[i].ipv4_tx_packets); - } -} #ifdef RTE_LIBRTE_BOND_DEBUG_ALB #define MODE6_DEBUG(info, src_ip, dst_ip, eth_h, arp_op, port, burstnumber) \ RTE_LOG(DEBUG, PMD, \ -- 2.2.2