From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f172.google.com (mail-we0-f172.google.com [74.125.82.172]) by dpdk.org (Postfix) with ESMTP id 6D5595A74 for ; Tue, 3 Mar 2015 20:48:49 +0100 (CET) Received: by wevl61 with SMTP id l61so42087826wev.2 for ; Tue, 03 Mar 2015 11:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N3dkgjWLAvUpli7skgXn8uo2EYGBvW45JLp7ngLeQOY=; b=IypsQIQSWi6zdzJeuY8tH6/jqxT5h5kzapAWLcb84yXg6ttlOo/56gVjW9BJTz5m93 q/HyzJyMvCeu2mn/IM8XE6SfDsmUP1hBV+WXlsUog49U0AvV4JaHck2nA31ACyPctSbJ 2jrjutlLSgyKcsYzLuZ6aPynpqe04V/HUQmVbFGdFvZPKQsL5i3kPBtxKJdqxDw2Q+Jm f5A+/Vmung6PobaKJGFRxSelAegqg1PfupnKNv+vZYk1sMu3TrVE60Z7yoiJhzA2IQ5y lVQ7o6j8CHHuw9hQ62Zdez/0ZRIWrRDLBRtwRqhYdN1IV755foRX8FSCCRIYuGyizBUI wb7w== X-Gm-Message-State: ALoCoQkwd4hyykbDf0TVrp8I7KOt+Vun4VTkSTuMFy2sUGmxGwhjzER8NbCADItuQivoBvnB692s X-Received: by 10.180.19.9 with SMTP id a9mr5890245wie.85.1425412129257; Tue, 03 Mar 2015 11:48:49 -0800 (PST) Received: from vladz-laptop.cloudius-systems.com. ([212.143.139.214]) by mx.google.com with ESMTPSA id k1sm2708022wjn.9.2015.03.03.11.48.48 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Mar 2015 11:48:48 -0800 (PST) From: Vlad Zolotarov To: dev@dpdk.org Date: Tue, 3 Mar 2015 21:48:40 +0200 Message-Id: <1425412123-5227-3-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425412123-5227-1-git-send-email-vladz@cloudius-systems.com> References: <1425412123-5227-1-git-send-email-vladz@cloudius-systems.com> Subject: [dpdk-dev] [PATCH v1 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Mar 2015 19:48:49 -0000 According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index 6c0e466..35a88d8 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3687,7 +3687,8 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) IXGBE_WRITE_REG(hw, IXGBE_RXCSUM, rxcsum); - if (hw->mac.type == ixgbe_mac_82599EB) { + if (hw->mac.type == ixgbe_mac_82599EB || + hw->mac.type == ixgbe_mac_X540) { rdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL); if (rx_conf->hw_strip_crc) rdrxctl |= IXGBE_RDRXCTL_CRCSTRIP; -- 2.1.0