From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f53.google.com (mail-wg0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id EFBDA5A85 for ; Thu, 5 Mar 2015 12:28:11 +0100 (CET) Received: by wghb13 with SMTP id b13so52735675wgh.0 for ; Thu, 05 Mar 2015 03:28:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N3dkgjWLAvUpli7skgXn8uo2EYGBvW45JLp7ngLeQOY=; b=A3rEi0zLGM+e/ZsMoqLIs489GM9tZcJFn/vYzyci2nkzA+wyUgH4QO2D4RJW12tydR EglTmGRXm2QQYtHwUXZULWxofklZF8+axwG7KnDO/q8h67idiwLP0h7xKaaEjWuegAmv 3VQxFr+jvjGY9pE5r6uzF3s6mJCPfYDEI5R99gTvf6y6T04lQYpZboN12T+E4E8ybmbI U6dNsA0I0cX6/vyqAf1rnrHxeP6B034q+7fLw1JK8nwxKP5eD9eZjubU/4gH0185JQwF lsrQBMJlf7uGL0BOG0jxPnhft2IrGMUFrXEntjdaLUwdqApd+0Dp5DV40I291SWDphj1 RYiA== X-Gm-Message-State: ALoCoQmUEQLTLYZVyrc50GDrQQLXWf2dRuBz7lnVWd2yhBzuHDchlvDYUTEDPbtLMhCMs1UEdD/h X-Received: by 10.194.239.134 with SMTP id vs6mr4973803wjc.158.1425554891872; Thu, 05 Mar 2015 03:28:11 -0800 (PST) Received: from vladz-laptop.cloudius-systems.com. ([212.143.139.214]) by mx.google.com with ESMTPSA id e2sm10069621wjy.46.2015.03.05.03.28.10 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2015 03:28:11 -0800 (PST) From: Vlad Zolotarov To: dev@dpdk.org Date: Thu, 5 Mar 2015 13:28:01 +0200 Message-Id: <1425554885-16901-3-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425554885-16901-1-git-send-email-vladz@cloudius-systems.com> References: <1425554885-16901-1-git-send-email-vladz@cloudius-systems.com> Subject: [dpdk-dev] [PATCH v2 2/6] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Mar 2015 11:28:12 -0000 According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index 6c0e466..35a88d8 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3687,7 +3687,8 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) IXGBE_WRITE_REG(hw, IXGBE_RXCSUM, rxcsum); - if (hw->mac.type == ixgbe_mac_82599EB) { + if (hw->mac.type == ixgbe_mac_82599EB || + hw->mac.type == ixgbe_mac_X540) { rdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL); if (rx_conf->hw_strip_crc) rdrxctl |= IXGBE_RDRXCTL_CRCSTRIP; -- 2.1.0