From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by dpdk.org (Postfix) with ESMTP id 5EDF27F6D for ; Fri, 6 Mar 2015 01:10:54 +0100 (CET) Received: by pablj1 with SMTP id lj1so40553971pab.8 for ; Thu, 05 Mar 2015 16:10:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=8XxE378XJAwOmAO2WT6AXL6QVmx/8Psc1w9am+LKAEw=; b=AyrFDHXV06Je6XuXromJFsuGFX2Xu3XQZ5/IwpFPf/pudaUMqMsIxLZ35NVBA7ldo9 5KP+VisEMrAJbHZeLrfgC7sJ43c3VHwSL3jkIos2388wByqpSsu5rT3dQE4o2F5ykVbm BGLHimC+WmiapwozQdfzA+/W3ONxq/ovPfa66RK/CLqtEeVGeuEgskr5TMbYu0h5R5CU cZJiy8kEM9xRO1vVxQ9PJ/iteL7/H/moACCZ8HyF/DR6LU8RXdIB+Sr/BjEXtrhu+XbM ZQWDKAWEjkWA9EhkuAT5JrG9um/tYsLAIFbgAszVQ+2ppr2CSzcdlCMDoC4zpjkSSLPB gpkQ== X-Gm-Message-State: ALoCoQm3XghC3QPzw4pfz361vnQtO0q5fAx5++Ln/c+i8Hk/Hq8s+9n1RH5wv2pFBWXf5NkOuuQ2 X-Received: by 10.68.244.2 with SMTP id xc2mr20170061pbc.45.1425600653769; Thu, 05 Mar 2015 16:10:53 -0800 (PST) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ms5sm7940550pbb.59.2015.03.05.16.10.52 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Mar 2015 16:10:52 -0800 (PST) From: Stephen Hemminger To: Yong Wang Date: Thu, 5 Mar 2015 16:10:35 -0800 Message-Id: <1425600635-20628-11-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1425600635-20628-1-git-send-email-stephen@networkplumber.org> References: <1425600635-20628-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger Subject: [dpdk-dev] [PATCH v3 10/10] vmxnet3: remove excess inlining X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2015 00:10:54 -0000 From: Stephen Hemminger No reason to inline large functions. Compiler will decide already based on optimization level. Also register array should be const. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index f6c3452..cabb505 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c @@ -84,10 +84,8 @@ #define RTE_MBUF_DATA_DMA_ADDR_DEFAULT(mb) \ (uint64_t) ((mb)->buf_physaddr + RTE_PKTMBUF_HEADROOM) -static uint32_t rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; +static const uint32_t rxprod_reg[2] = {VMXNET3_REG_RXPROD, VMXNET3_REG_RXPROD2}; -static inline int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t* , uint8_t); -static inline void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *); #ifdef RTE_LIBRTE_VMXNET3_DEBUG_DRIVER_NOT_USED static void vmxnet3_rxq_dump(struct vmxnet3_rx_queue *); static void vmxnet3_txq_dump(struct vmxnet3_tx_queue *); @@ -157,7 +155,7 @@ vmxnet3_txq_dump(struct vmxnet3_tx_queue *txq) } #endif -static inline void +static void vmxnet3_cmd_ring_release_mbufs(vmxnet3_cmd_ring_t *ring) { while (ring->next2comp != ring->next2fill) { @@ -296,7 +294,7 @@ vmxnet3_dev_clear_queues(struct rte_eth_dev *dev) } } -static inline void +static void vmxnet3_tq_tx_complete(vmxnet3_tx_queue_t *txq) { int completed = 0; @@ -472,7 +470,7 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, * only for LRO. * */ -static inline int +static int vmxnet3_post_rx_bufs(vmxnet3_rx_queue_t *rxq, uint8_t ring_id) { int err = 0; -- 2.1.4