From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by dpdk.org (Postfix) with ESMTP id D0FC05A85 for ; Fri, 6 Mar 2015 01:10:45 +0100 (CET) Received: by pabrd3 with SMTP id rd3so22796583pab.5 for ; Thu, 05 Mar 2015 16:10:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jWPUBalcYE4luefN0ST8Qe7tE8BFwb8slS/tHNYQ1T0=; b=PJ3W8yzooWxN8UczgKeHsY1d6bs8BAvztUW3meyBknqY1x9Uqa9ZGL3GZuqoeL+Oh7 hiU0pL4q4t6LHsKX+6R4QUpasdXYd+3AKVBqUekVgQKIeUXCi3C3nxKmCcjavvwd0m1H gnx1Iui6ITRoSUnqDdahuIbvTOztRUti0LOya1dB2kPS+YtNn6J67Y+cHrjQ8rmUbdI/ m/2ofQG9hqellgEzfcfwI5vMGdvsD4eZu6Y8UMJPaFE/wfZn4RbGJNkEMeBJEnOc52Rg Z+bTLda/rgjdyuKCCFyH1OLuOVDzbDT0bDqF2NWtlEDkuqoh8pRljxdmZEXx2rWgQlyd rz7w== X-Gm-Message-State: ALoCoQnO7BEGQHgGNxQiBaOJJpRmWn1TSluIIJtSBizRbOu6XGsuzTrete3c/9TrRCT992q8IXnE X-Received: by 10.66.62.201 with SMTP id a9mr20319334pas.101.1425600645025; Thu, 05 Mar 2015 16:10:45 -0800 (PST) Received: from urahara.brocade.com (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id ms5sm7940550pbb.59.2015.03.05.16.10.43 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 05 Mar 2015 16:10:43 -0800 (PST) From: Stephen Hemminger To: Yong Wang Date: Thu, 5 Mar 2015 16:10:28 -0800 Message-Id: <1425600635-20628-4-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1425600635-20628-1-git-send-email-stephen@networkplumber.org> References: <1425600635-20628-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org, Stephen Hemminger Subject: [dpdk-dev] [PATCH v3 03/10] vmxnet3: remove mtu check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2015 00:10:46 -0000 From: Stephen Hemminger Remove check for packets greater than MTU. No other driver does this, it should be handled at higher layer Signed-off-by: Stephen Hemminger Acked-by: Yong Wang --- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c | 2 -- lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h | 1 - lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 10 ---------- 3 files changed, 13 deletions(-) diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c index f4c2f12..35bb561 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.c @@ -246,7 +246,6 @@ eth_vmxnet3_dev_init(__attribute__((unused)) struct eth_driver *eth_drv, hw->num_rx_queues = 1; hw->num_tx_queues = 1; - hw->cur_mtu = ETHER_MTU; hw->bufs_per_pkt = 1; /* Check h/w version compatibility with driver. */ @@ -422,7 +421,6 @@ vmxnet3_setup_driver_shared(struct rte_eth_dev *dev) devRead->misc.mtu = rte_le_to_cpu_32(dev->data->mtu); devRead->misc.queueDescPA = hw->queueDescPA; devRead->misc.queueDescLen = hw->queue_desc_len; - devRead->misc.mtu = hw->cur_mtu; devRead->misc.numTxQueues = hw->num_tx_queues; devRead->misc.numRxQueues = hw->num_rx_queues; diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h index e9d67a7..83182e2 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h +++ b/lib/librte_pmd_vmxnet3/vmxnet3_ethdev.h @@ -107,7 +107,6 @@ struct vmxnet3_hw { uint8_t num_tx_queues; uint8_t num_rx_queues; uint8_t bufs_per_pkt; - uint16_t cur_mtu; Vmxnet3_TxQueueDesc *tqd_start; /* start address of all tx queue desc */ Vmxnet3_RxQueueDesc *rqd_start; /* start address of all rx queue desc */ diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c index 5fe3de5..38ac811 100644 --- a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c +++ b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c @@ -369,16 +369,6 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, continue; } - /* Needs to minus ether header len */ - if (txm->data_len > (hw->cur_mtu + ETHER_HDR_LEN)) { - PMD_TX_LOG(DEBUG, "Packet data_len higher than MTU"); - rte_pktmbuf_free(tx_pkts[nb_tx]); - txq->stats.drop_total++; - - nb_tx++; - continue; - } - txd = (Vmxnet3_TxDesc *)(txq->cmd_ring.base + txq->cmd_ring.next2fill); if (rte_pktmbuf_pkt_len(txm) <= VMXNET3_HDR_COPY_SIZE) { struct Vmxnet3_TxDataDesc *tdd; -- 2.1.4