DPDK patches and discussions
 help / color / mirror / Atom feed
From: Michael Qiu <michael.qiu@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] librte_pmd_fm10k: Set pointer to NULL after free
Date: Fri,  6 Mar 2015 15:56:47 +0800
Message-ID: <1425628607-1497-1-git-send-email-michael.qiu@intel.com> (raw)

It could be a potential not safe issue.

Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
 lib/librte_pmd_fm10k/fm10k_ethdev.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/lib/librte_pmd_fm10k/fm10k_ethdev.c b/lib/librte_pmd_fm10k/fm10k_ethdev.c
index 07ea1e7..30962d3 100644
--- a/lib/librte_pmd_fm10k/fm10k_ethdev.c
+++ b/lib/librte_pmd_fm10k/fm10k_ethdev.c
@@ -142,9 +142,12 @@ rx_queue_free(struct fm10k_rx_queue *q)
 	if (q) {
 		PMD_INIT_LOG(DEBUG, "Freeing rx queue %p", q);
 		rx_queue_clean(q);
-		if (q->sw_ring)
+		if (q->sw_ring) {
 			rte_free(q->sw_ring);
+			q->sw_ring = NULL;
+		}
 		rte_free(q);
+		q = NULL;
 	}
 }
 
@@ -225,11 +228,16 @@ tx_queue_free(struct fm10k_tx_queue *q)
 	if (q) {
 		PMD_INIT_LOG(DEBUG, "Freeing tx queue %p", q);
 		tx_queue_clean(q);
-		if (q->rs_tracker.list)
+		if (q->rs_tracker.list) {
 			rte_free(q->rs_tracker.list);
-		if (q->sw_ring)
+			q->rs_tracker.list = NULL;
+		}
+		if (q->sw_ring) {
 			rte_free(q->sw_ring);
+			q->sw_ring = NULL;
+		}
 		rte_free(q);
+		q = NULL;
 	}
 }
 
-- 
1.9.3

             reply	other threads:[~2015-03-06  7:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-06  7:56 Michael Qiu [this message]
2015-03-16  1:46 ` Chen, Jing D
2015-03-16 23:42   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425628607-1497-1-git-send-email-michael.qiu@intel.com \
    --to=michael.qiu@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git