From: Konstantin Ananyev <konstantin.ananyev@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCHv2] headers: typeof -> __typeof__ to unbreak C++11 code
Date: Fri, 6 Mar 2015 15:59:47 +0000 [thread overview]
Message-ID: <1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com> (raw)
In-Reply-To: <20150225142851.55406347@miho>
In-Reply-To: <20150225142851.55406347@miho>
v2:
Instead of changing all the affected files,
define 'typeofi' and 'asm' if needed.
When compiling C++11-code or above (--std=c++11), the build fails with
lots of
rte_eth_ctrl.h:517:3: note: in expansion of macro RTE_ALIGN
(RTE_ALIGN(RTE_ETH_FLOW_MAX, UINT32_BIT)/UINT32_BIT)
^
When reading the GCC info pages, I get the feeling that __typeof__ is
a better choice, and that indeed works when including the headers in
C++ files (--std=c++11).
There are some typeof()s left in C files, the patch only touches the
public API.
Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
---
lib/librte_eal/common/include/rte_common.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h
index 8ac940c..1867692 100644
--- a/lib/librte_eal/common/include/rte_common.h
+++ b/lib/librte_eal/common/include/rte_common.h
@@ -51,6 +51,15 @@ extern "C" {
#include <errno.h>
#include <limits.h>
+#ifndef typeof
+#define typeof __typeof__
+#endif
+
+#ifndef asm
+#define asm __asm__
+#endif
+
+
/*********** Macros to eliminate unused variable warnings ********/
/**
--
1.8.5.3
next prev parent reply other threads:[~2015-03-06 16:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 13:28 [dpdk-dev] [PATCH] " Simon Kagstrom
2015-02-26 11:14 ` Thomas Monjalon
2015-02-26 11:24 ` Simon Kågström
2015-02-26 16:02 ` Mcnamara, John
2015-02-27 16:24 ` Ananyev, Konstantin
2015-03-02 7:55 ` Simon Kågström
2015-03-06 8:28 ` Simon Kågström
2015-03-06 10:30 ` Ananyev, Konstantin
2015-03-06 13:42 ` Simon Kågström
2015-03-06 15:59 ` Konstantin Ananyev [this message]
2015-03-09 16:38 ` [dpdk-dev] [PATCHv2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425657587-23516-1-git-send-email-konstantin.ananyev@intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).