From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vladz@cloudius-systems.com>
Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 22D4C5FEB
 for <dev@dpdk.org>; Sun,  8 Mar 2015 15:05:03 +0100 (CET)
Received: by wggx13 with SMTP id x13so22356442wgg.12
 for <dev@dpdk.org>; Sun, 08 Mar 2015 07:05:02 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id;
 bh=eSz5Q8swvRgo1fUlPxmh4j3sWK9oJhEWvyMElxd8P/g=;
 b=mWAeUMnUtx66/gDtDFkY9me8bB9IyIOCuPEV8GmgOetD4KjfVE7uNEX6rW4QYCeN0v
 ny73spLRBvIO2Z0PhJCqrMag/wsB/t92he+JbAdH+Gc5Fr0GU27wlTf/F0x4uZNNjZlz
 0NAuKzaqAOA5oGjnmCz6320WwKZR7S5lvxN8SrVgQsdMYEkWSKUD8p/uD5AJ8PVkdCx7
 fHdlAFvxjmsjxS6S+cQs9kiDD8H00FRhT5wW5IGb40r/wGVVRDRj3QKoBLpown9rQVC3
 JG4PVBeII5PpHBnrwA+J96ObYzGiPhGe2swaySRAK8k6vydn/deFDdO66e6/hQ7cQF+s
 VMyA==
X-Gm-Message-State: ALoCoQlwNwTpBq5srW2DGndSjmScWsTGJo8xOuF3tTgQiPuUtmREQ7CyPq8fQH+Wjs9dTpatWdfK
X-Received: by 10.180.74.202 with SMTP id w10mr23241111wiv.0.1425823502826;
 Sun, 08 Mar 2015 07:05:02 -0700 (PDT)
Received: from vladz-laptop.cloudius-systems.com. ([212.143.139.214])
 by mx.google.com with ESMTPSA id fo8sm11196154wib.14.2015.03.08.07.05.01
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Sun, 08 Mar 2015 07:05:01 -0700 (PDT)
From: Vlad Zolotarov <vladz@cloudius-systems.com>
To: dev@dpdk.org
Date: Sun,  8 Mar 2015 16:04:53 +0200
Message-Id: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com>
X-Mailer: git-send-email 2.1.0
Subject: [dpdk-dev]  [PATCH v4 0/5]: Add LRO support to ixgbe PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Mar 2015 14:05:03 -0000

This series adds the missing flow for enabling the LRO in the ethdev and
adds a support for this feature in the ixgbe PMD. There is a big hope that this
initiative is going to be picked up by some Intel developer that would add the LRO support
to other Intel PMDs. ;)
 
The series starts with some cleanup work in the code the final patch (the actual adding of
the LRO support) is going to touch/use/change. There are still quite a few issues in the ixgbe
PMD code left but they have to be a matter of a different series and I've left a few "TODO"
remarks in the code.
 
The LRO ("RSC" in Intel's context) PMD completion handling code follows the same design as the
corresponding Linux and FreeBSD implementation: pass the aggregation's cluster HEAD buffer to
the NEXTP entry of the software ring till EOP is met.
 
HW configuration follows the corresponding specs: this feature is supported only by x540 and
82599 PF devices.
 
The feature has been tested with seastar TCP stack with the following configuration on Tx side:
   - MTU: 400B
   - 100 concurrent TCP connections.
 
The results were:
   - Without LRO: total throughput: 0.12Gbps, coefficient of variance: 1.41%
   - With LRO:    total throughput: 8.21Gbps, coefficient of variance: 0.59%
 
This is an almost factor 80 improvement.

New in v4:
   - Remove CONFIG_RTE_ETHDEV_LRO_SUPPORT from config/common_linuxapp.
   - Define RTE_ETHDEV_HAS_LRO_SUPPORT in rte_ethdev.h.
   - As a result of "ixgbe: check rxd number to avoid mbuf leak" (352078e8e) Vector Rx
     had to get the same treatment as Rx Bulk Alloc (see PATCH4 for more details).
     
New in v3:
   - ixgbe_rx_alloc_bufs(): Always reset refcnt of the buffers to 1. Otherwise rte_pktmbuf_free()
     won't free them.

New in v2:
   - Removed rte_eth_dev_data.lro_bulk_alloc and added ixgbe_hw.rx_bulk_alloc_allowed
     instead.
   - Unified the rx_pkt_bulk callback setting (a separate new patch).
   - Fixed a few styling and spelling issues.

Vlad Zolotarov (5):
  ixgbe: Cleanups
  ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices
  ixgbe: Code refactoring
  ixgbe: Unify the rx_pkt_bulk callback initialization
  ixgbe: Add LRO support

 lib/librte_ether/rte_ethdev.h           |   9 +-
 lib/librte_pmd_ixgbe/ixgbe/ixgbe_type.h |   2 +
 lib/librte_pmd_ixgbe/ixgbe_ethdev.c     |  19 +-
 lib/librte_pmd_ixgbe/ixgbe_ethdev.h     |   5 +
 lib/librte_pmd_ixgbe/ixgbe_rxtx.c       | 886 +++++++++++++++++++++++++++-----
 lib/librte_pmd_ixgbe/ixgbe_rxtx.h       |  28 +-
 6 files changed, 815 insertions(+), 134 deletions(-)

-- 
2.1.0