From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f169.google.com (mail-we0-f169.google.com [74.125.82.169]) by dpdk.org (Postfix) with ESMTP id 94BF16A80 for ; Sun, 8 Mar 2015 15:05:05 +0100 (CET) Received: by wesu56 with SMTP id u56so1687045wes.12 for ; Sun, 08 Mar 2015 07:05:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hFqb5I1GagjfmLPBkSqMNXRWzBgMI0Ry6YjPIBS22pE=; b=PPb+ugQKv1olqEGiJvPMuSDIwd+2DJL54wL4I1tMapWPXHH2S0Q1fu8zmoVonXnVPY GqsF/QRqTWdvNrmEEnKSgx4LDz+1p9OJZiwJwUECeJiT2n65G1HWD8awu4lsoa1HnkHr SoRbxIXBcRuoxon8UGd/g7c8arf9pY3WFBKFdyoW055iS/n3wIar7sh7k1P8U0Gl/Hov yFGZpqVVhb0OY0q9w11oQnHR5T+6v37R924R5OVT56Q0AdV/5kWfTry6O7gfUd0jK+9m M778S4BtKvJlz8Y7868OrJ+bMVA25cWn+JGNJL406O4KnxjrPwvKZbjpjjm0xsnXhVzV /pcg== X-Gm-Message-State: ALoCoQlB70M9zpIEsXDEkeHQ/qXLMzCoFw5PZHmQ0mLWeRfXwQbHOeFk9TXPP9GUFbseGWiO3n7P X-Received: by 10.180.212.70 with SMTP id ni6mr36786965wic.8.1425823505482; Sun, 08 Mar 2015 07:05:05 -0700 (PDT) Received: from vladz-laptop.cloudius-systems.com. ([212.143.139.214]) by mx.google.com with ESMTPSA id fo8sm11196154wib.14.2015.03.08.07.05.04 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 08 Mar 2015 07:05:04 -0700 (PDT) From: Vlad Zolotarov To: dev@dpdk.org Date: Sun, 8 Mar 2015 16:04:55 +0200 Message-Id: <1425823498-30385-3-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> References: <1425823498-30385-1-git-send-email-vladz@cloudius-systems.com> Subject: [dpdk-dev] [PATCH v4 2/5] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Mar 2015 14:05:05 -0000 According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index fe362e4..e370e0a 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3680,7 +3680,8 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) IXGBE_WRITE_REG(hw, IXGBE_RXCSUM, rxcsum); - if (hw->mac.type == ixgbe_mac_82599EB) { + if (hw->mac.type == ixgbe_mac_82599EB || + hw->mac.type == ixgbe_mac_X540) { rdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL); if (rx_conf->hw_strip_crc) rdrxctl |= IXGBE_RDRXCTL_CRCSTRIP; -- 2.1.0