From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 815CA9A8F for ; Mon, 9 Mar 2015 11:12:55 +0100 (CET) Received: by wiwh11 with SMTP id h11so8345393wiw.1 for ; Mon, 09 Mar 2015 03:12:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eemCL7OvUUdQ6AAdN+ICcJzm1dt2FTXCVcPpASiUfoI=; b=LlR3anIDIeUmnCm4UIyGCZ6m97W+akyVFescqgIc9kZEWsx/OHMpVtzTwcp/vu68JI jg2TISfziXLiA/TDpGSyZ4BDeXJ3/OTZ7Zbkvj0ZFZU0O9nFcD6Vo8fEMH9dGepcPM0m bT8sHMQAlAY9TT5UW7h2L+1p6uknNHHjZUQBw7ltWW0QIC9BBArgDego1LrUhLlvZHzA s7P3Slhv2Mv3gpYXFZ3C9fSTtWkLvdPNtNSgecDdS41RoXcMXToXJRz2Zw+/Ph1hQzyl D78tH+JnYH5BXF1Ed7uHL6rY0px8SvTRrZ7SatuawJMKgwt+BgEi9SHCNz2rvLGiHZrv s/AQ== X-Gm-Message-State: ALoCoQl+XX2pkHmJCKI94RHd46eL7VLdrYE2iTgt402ziVHSH7Cy2Ngb3luLzcNkAfqvlmJOfotL X-Received: by 10.180.108.13 with SMTP id hg13mr58019174wib.7.1425895975407; Mon, 09 Mar 2015 03:12:55 -0700 (PDT) Received: from vladz-laptop.localdomain (bzq-109-65-117-109.red.bezeqint.net. [109.65.117.109]) by mx.google.com with ESMTPSA id vh8sm27570353wjc.12.2015.03.09.03.12.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Mar 2015 03:12:54 -0700 (PDT) From: Vlad Zolotarov To: dev@dpdk.org Date: Mon, 9 Mar 2015 12:12:47 +0200 Message-Id: <1425895968-8597-3-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1425895968-8597-1-git-send-email-vladz@cloudius-systems.com> References: <1425895968-8597-1-git-send-email-vladz@cloudius-systems.com> Subject: [dpdk-dev] [PATCH v1 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2015 10:12:55 -0000 According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index b033e04..ce9658e 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3677,7 +3677,8 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) IXGBE_WRITE_REG(hw, IXGBE_RXCSUM, rxcsum); - if (hw->mac.type == ixgbe_mac_82599EB) { + if (hw->mac.type == ixgbe_mac_82599EB || + hw->mac.type == ixgbe_mac_X540) { rdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL); if (dev->data->dev_conf.rxmode.hw_strip_crc) rdrxctl |= IXGBE_RDRXCTL_CRCSTRIP; -- 2.1.0