DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] example: fix minor bug in l2fwd-jobstats init sequence
Date: Mon,  9 Mar 2015 17:05:29 +0100	[thread overview]
Message-ID: <1425917129-5090-1-git-send-email-pawelx.wodkowski@intel.com> (raw)

Fix check of returned values during application init phase.

Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>
---
 examples/l2fwd-jobstats/main.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c
index a5a1aaa..ba9d3c0 100644
--- a/examples/l2fwd-jobstats/main.c
+++ b/examples/l2fwd-jobstats/main.c
@@ -997,11 +997,11 @@ main(int argc, char **argv)
 				drain_tsc, 0);
 
 		rte_timer_init(&qconf->flush_timer);
-		rte_timer_reset(&qconf->flush_timer, drain_tsc, PERIODICAL, lcore_id,
-				&l2fwd_flush_job, NULL);
+		ret = rte_timer_reset(&qconf->flush_timer, drain_tsc, PERIODICAL,
+				lcore_id, &l2fwd_flush_job, NULL);
 
 		if (ret < 0) {
-			rte_exit(1, "Failed to add flush job for lcore %u: %s",
+			rte_exit(1, "Failed to reset flush job timer for lcore %u: %s",
 					lcore_id, rte_strerror(-ret));
 		}
 
@@ -1019,8 +1019,13 @@ main(int argc, char **argv)
 			rte_jobstats_set_update_period_function(job, l2fwd_job_update_cb);
 
 			rte_timer_init(&qconf->rx_timers[i]);
-			rte_timer_reset(&qconf->rx_timers[i], 0, PERIODICAL, lcore_id,
+			ret = rte_timer_reset(&qconf->rx_timers[i], 0, PERIODICAL, lcore_id,
 					&l2fwd_fwd_job, (void *)(uintptr_t)i);
+
+			if (ret < 0) {
+				rte_exit(1, "Failed to reset lcore %u port %u job timer: %s",
+						lcore_id, qconf->rx_port_list[i], rte_strerror(-ret));
+			}
 		}
 	}
 
-- 
1.9.1

             reply	other threads:[~2015-03-09 16:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-09 16:05 Pawel Wodkowski [this message]
2015-03-09 16:16 ` Pawel Wodkowski
2015-03-10 15:13 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425917129-5090-1-git-send-email-pawelx.wodkowski@intel.com \
    --to=pawelx.wodkowski@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).