[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Yong Liu]

testpmd parameter "nb-port" mean the number of forwarding port.
It's incorrect to use function port_id_is_invalid to check number of ports.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 11d9af0..f1daa6e 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
 #endif
 			if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
 				n = atoi(optarg);
-				if (n > 0 &&
-				    !port_id_is_invalid(n, DISABLED_WARN))
+				if (n > 0 && n <= nb_ports)
 					nb_fwd_ports = (uint8_t) n;
 				else
 					rte_exit(EXIT_FAILURE,
-- 
1.9.3

Re: [dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Thomas Monjalon]

2015-03-11 15:23, Yong Liu:
> testpmd parameter "nb-port" mean the number of forwarding port.
> It's incorrect to use function port_id_is_invalid to check number of ports.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

Fixes: edab33b1c01d ("app/testpmd: support port hotplug")

Applied, thanks

[dpdk-dev] [PATCH 0/6] fix build warnings and errors in SUSE11 SP3

[Yong Liu]

From: Marvin Liu <yong.liu@intel.com>

SUSE11 SP3 default gcc version is 4.3.4. Some options not supported in this
version. This patch set add gcc version check for those options and fix other
build warning in Suse11 SP3.

Marvin Liu (6):
  fix sse3 functions not found with gcc 4.3.4
  fix fm10k driver build error when gcc version elder than 4.4
  fix build error when initialized structure in enic driver
  fix build error in app/test with gcc4.3
  fix build error in app/test with gcc4.3
  fix build error for implicit declaration of function pread

 app/test/Makefile                               |  2 ++
 app/test/test.h                                 |  2 +-
 lib/librte_eal/common/include/rte_common_vect.h |  4 ++++
 lib/librte_eal/linuxapp/eal/Makefile            |  2 ++
 lib/librte_pmd_enic/enic_main.c                 | 10 ++++++----
 lib/librte_pmd_fm10k/Makefile                   | 10 ++++++----
 lib/librte_pmd_ixgbe/Makefile                   |  5 +++--
 7 files changed, 24 insertions(+), 11 deletions(-)

-- 
1.9.3

[dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Yong Liu]

testpmd parameter "nb-port" mean the number of forwarding port.
It's incorrect to use function port_id_is_invalid to check number of ports.

Signed-off-by: Marvin Liu <yong.liu@intel.com>

diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
index 11d9af0..f1daa6e 100644
--- a/app/test-pmd/parameters.c
+++ b/app/test-pmd/parameters.c
@@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
 #endif
 			if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
 				n = atoi(optarg);
-				if (n > 0 &&
-				    !port_id_is_invalid(n, DISABLED_WARN))
+				if (n > 0 && n <= nb_ports)
 					nb_fwd_ports = (uint8_t) n;
 				else
 					rte_exit(EXIT_FAILURE,
-- 
1.9.3

Re: [dpdk-dev] [PATCH] app/test-pmd: fix incorrect port number check

[Thomas Monjalon]

This patch was already applied:
	http://dpdk.org/browse/dpdk/commit/?id=0a530f0d58b030

2015-03-19 11:16, Yong Liu:
> testpmd parameter "nb-port" mean the number of forwarding port.
> It's incorrect to use function port_id_is_invalid to check number of ports.
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> 
> diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c
> index 11d9af0..f1daa6e 100644
> --- a/app/test-pmd/parameters.c
> +++ b/app/test-pmd/parameters.c
> @@ -628,8 +628,7 @@ launch_args_parse(int argc, char** argv)
>  #endif
>  			if (!strcmp(lgopts[opt_idx].name, "nb-ports")) {
>  				n = atoi(optarg);
> -				if (n > 0 &&
> -				    !port_id_is_invalid(n, DISABLED_WARN))
> +				if (n > 0 && n <= nb_ports)
>  					nb_fwd_ports = (uint8_t) n;
>  				else
>  					rte_exit(EXIT_FAILURE,
>