From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id DC84D5947 for ; Thu, 12 Mar 2015 22:17:38 +0100 (CET) Received: by wghl2 with SMTP id l2so19179731wgh.8 for ; Thu, 12 Mar 2015 14:17:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vI2nqd50DXfGRxuDLgBXIIYhPTWIIrgKYnJ9GoLB5bE=; b=bjgiu9RhBdMbapBYBQ+NPb3a7vdpIf3/yN/XCSnUyWYb3T0vdatrwQ1IssgX5tQUge Vtf29p/pUWxlHl3h0WkIkiC+edAz6GvnOeRxLJkURkhllpobAOYrQW+OTM90oh7KGtHk MXFuDjw/4E1nibNO0W7d3njWzabPURF4VjOBIJnNQlW+7FqcPGlzhGk8I1pDXPPGWrmc mGVwTnjeawrWMVTudxc5aSO7wzeeKTDqjvSduGEOYSwKiF2vVrD7HU7R44MGslx8X7wl PY9zPu6Xwmc8snGm5H3bJArjbM5x1+YGZ72djk3vHkyioPIjlxr6LIOwowKaW7oyxPqr FsVw== X-Gm-Message-State: ALoCoQlkfJbwruTRV1gBzpSpw4CDs5X0nSaJWoU2uI+vkFDFKdyp1/RcRn942eXW3SxpUiRT0WUy X-Received: by 10.180.187.12 with SMTP id fo12mr69525903wic.29.1426195058684; Thu, 12 Mar 2015 14:17:38 -0700 (PDT) Received: from vladz-laptop.localdomain (bzq-109-65-117-109.red.bezeqint.net. [109.65.117.109]) by mx.google.com with ESMTPSA id cf12sm68579wjb.10.2015.03.12.14.17.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Mar 2015 14:17:37 -0700 (PDT) From: Vlad Zolotarov To: dev@dpdk.org Date: Thu, 12 Mar 2015 23:17:31 +0200 Message-Id: <1426195052-4640-3-git-send-email-vladz@cloudius-systems.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> References: <1426195052-4640-1-git-send-email-vladz@cloudius-systems.com> Subject: [dpdk-dev] [PATCH v3 2/3] ixgbe: Bug fix: Properly configure Rx CRC stripping for x540 devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2015 21:17:39 -0000 According to x540 spec chapter 8.2.4.8.9 CRCSTRIP field of RDRXCTL should be configured to the same value as HLREG0.RXCRCSTRP. Clearing the RDRXCTL.RSCFRSTSIZE field for x540 is not required by the spec but seems harmless. Signed-off-by: Vlad Zolotarov --- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index f7c081f..92be61e 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -3680,7 +3680,8 @@ ixgbe_dev_rx_init(struct rte_eth_dev *dev) IXGBE_WRITE_REG(hw, IXGBE_RXCSUM, rxcsum); - if (hw->mac.type == ixgbe_mac_82599EB) { + if (hw->mac.type == ixgbe_mac_82599EB || + hw->mac.type == ixgbe_mac_X540) { rdrxctl = IXGBE_READ_REG(hw, IXGBE_RDRXCTL); if (dev->data->dev_conf.rxmode.hw_strip_crc) rdrxctl |= IXGBE_RDRXCTL_CRCSTRIP; -- 2.1.0