From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <prvs=0514ea96d7=agartrell@fb.com>
Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com
[67.231.145.42]) by dpdk.org (Postfix) with ESMTP id C574B6942
for <dev@dpdk.org>; Fri, 13 Mar 2015 20:21:58 +0100 (CET)
Received: from pps.filterd (m0004346 [127.0.0.1])
by mx0a-00082601.pphosted.com (8.14.5/8.14.5) with SMTP id t2DJEGrj028332
for <dev@dpdk.org>; Fri, 13 Mar 2015 12:21:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com;
h=from : to : cc : subject :
date : message-id : mime-version : content-type; s=facebook;
bh=6udtG2o0bfUM2rYMO7X8rVch5JZ+Qk6ezgAv03i8skk=;
b=puvnOyYBniU89iI+NE63uX+kJ7SWRePEmQghx6+UZAbKAMckR8hlg8py1CJbUsXS8JoB
Mf432qKlBOvLJjqQ3i/Ej09B13r7r7un0v4YKXMBFowbyyHKarJn7rrgL5Vfgp9FQ+mp
3i7fIC4Lc0BeDpZTjuZcEoKSdEsAbAAO59E=
Received: from mail.thefacebook.com ([199.201.64.23])
by mx0a-00082601.pphosted.com with ESMTP id 1t45nf81mx-12
(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT)
for <dev@dpdk.org>; Fri, 13 Mar 2015 12:21:57 -0700
Received: from mx-out.facebook.com (192.168.57.29) by
PRN-CHUB13.TheFacebook.com (192.168.16.23) with Microsoft SMTP Server (TLS)
id 14.3.195.1; Fri, 13 Mar 2015 12:21:51 -0700
Received: from facebook.com (2401:db00:20:7017:face:0:13:0) by
mx-out.facebook.com (10.212.236.89) with ESMTP id
33541d18c9b611e495060002c95209d8-d37fa390 for <dev@dpdk.org>; Fri, 13 Mar
2015 12:21:51 -0700
Received: by devbig020.prn2.facebook.com (Postfix, from userid 4221) id
A73786841F97; Fri, 13 Mar 2015 12:21:50 -0700 (PDT)
From: Alex Gartrell <agartrell@fb.com>
To: <dev@dpdk.org>
Date: Fri, 13 Mar 2015 12:21:43 -0700
Message-ID: <1426274503-372191-1-git-send-email-agartrell@fb.com>
X-Mailer: git-send-email 1.8.1
X-FB-Internal: Safe
MIME-Version: 1.0
Content-Type: text/plain
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68, 1.0.33,
0.0.0000
definitions=2015-03-13_07:2015-03-13,2015-03-13,1970-01-01 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0
kscore.is_bulkscore=0
kscore.compositescore=1 circleOfTrustscore=0
compositescore=0.925924926977281 suspectscore=1
recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0
kscore.is_spamscore=0 rbsscore=0.925924926977281
recipient_to_sender_totalscore=0
recipient_domain_to_sender_domain_totalscore=0 spamscore=0
recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.925924926977281
adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=7.0.1-1402240000 definitions=main-1503130186
X-FB-Internal: deliver
Cc: kernel-team@fb.com
Subject: [dpdk-dev] [PATCH] eal: remove unnecessary #ifdef CONFIG_BQL
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Mar 2015 19:21:59 -0000
I couldn't figure out why this #ifdef existed so I looked around upstream
and it's not there. It seems to build just fine without it.
Signed-off-by: Alex Gartrell <agartrell@fb.com>
---
lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
index a582f52..d58e1f3 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb.h
@@ -472,12 +472,10 @@ static inline u16 igb_desc_unused(const struct igb_ring *ring)
return ((ntc > ntu) ? 0 : ring->count) + ntc - ntu - 1;
}
-#ifdef CONFIG_BQL
static inline struct netdev_queue *txring_txq(const struct igb_ring *tx_ring)
{
return netdev_get_tx_queue(tx_ring->netdev, tx_ring->queue_index);
}
-#endif /* CONFIG_BQL */
// #ifdef EXT_THERMAL_SENSOR_SUPPORT
// #ifdef IGB_PROCFS
--
Alex Gartrell <agartrell@fb.com>