From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
[209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 790FD7E23
for <dev@dpdk.org>; Wed, 25 Mar 2015 18:00:44 +0100 (CET)
Received: by wibg7 with SMTP id g7so117175288wib.1
for <dev@dpdk.org>; Wed, 25 Mar 2015 10:00:44 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
:references;
bh=iA8Lhjeks+wfmXzNZZKvf5tVwXCAmxMgop3lv1qLTRQ=;
b=lDgDaw+u6u9RfjrHGPU6Sihh6pemuI3ZzYYlXX+/yKWFZRloigc4DES5dGkiBqTnn8
GD5WyEU5FKibYcyRJuS1euIkx2x76WQCn/KxJDG6+uOfXePJrCC83dRrYEEw46tp41bP
DZJB+VsM8qNiaM3SYrgLs2UGIN7hJupVpuqeF/hiQAGUUIDZY3xUjS4n1HDIExtmh/Qk
Hv+jcNa7ZIfYklMHB4QIX6dE9EcnDAQnuZONp5xpRhF4sizfPViU2/SCmUNikzdbLgDv
04E8xsfNBB6yBsZ4nlsvuSJwj325MD3YPnxPrTWe8sLfo4y9pS9CiEE3zH9HymzyowQV
+s/w==
X-Gm-Message-State: ALoCoQnki4uo6KUFGRhU07IUPlPu75PJJLUu1Y/zqO+em4vAyMKpYU+GZmHVaGcBhv6FX82m30cM
X-Received: by 10.194.156.202 with SMTP id wg10mr20378870wjb.70.1427302844021;
Wed, 25 Mar 2015 10:00:44 -0700 (PDT)
Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237])
by mx.google.com with ESMTPSA id
wo10sm4513373wjb.35.2015.03.25.10.00.43
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Wed, 25 Mar 2015 10:00:43 -0700 (PDT)
From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Date: Wed, 25 Mar 2015 18:00:34 +0100
Message-Id: <1427302838-8285-2-git-send-email-olivier.matz@6wind.com>
X-Mailer: git-send-email 2.1.4
In-Reply-To: <1427302838-8285-1-git-send-email-olivier.matz@6wind.com>
References: <1427302838-8285-1-git-send-email-olivier.matz@6wind.com>
Subject: [dpdk-dev] [PATCH 1/5] mbuf: fix clone support when application
uses private mbuf data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Mar 2015 17:00:44 -0000
Add a new private_size field in mbuf structure that should
be initialized at mbuf pool creation. This field contains the
size of the application private data in mbufs.
Introduce new static inline functions rte_mbuf_from_baddr()
and rte_mbuf_to_baddr() to replace the existing macros, which
take the private size in account when attaching and detaching
mbufs.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
app/test-pmd/testpmd.c | 1 +
examples/vhost/main.c | 6 ++----
lib/librte_mbuf/rte_mbuf.c | 1 +
lib/librte_mbuf/rte_mbuf.h | 44 +++++++++++++++++++++++++++++++++++---------
4 files changed, 39 insertions(+), 13 deletions(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index 3057791..c5a195a 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -425,6 +425,7 @@ testpmd_mbuf_ctor(struct rte_mempool *mp,
mb->tx_offload = 0;
mb->vlan_tci = 0;
mb->hash.rss = 0;
+ mb->priv_size = 0;
}
static void
diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index c3fcb80..050f3ac 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -139,8 +139,6 @@
/* Number of descriptors per cacheline. */
#define DESC_PER_CACHELINE (RTE_CACHE_LINE_SIZE / sizeof(struct vring_desc))
-#define MBUF_EXT_MEM(mb) (RTE_MBUF_FROM_BADDR((mb)->buf_addr) != (mb))
-
/* mask of enabled ports */
static uint32_t enabled_port_mask = 0;
@@ -1590,7 +1588,7 @@ txmbuf_clean_zcp(struct virtio_net *dev, struct vpool *vpool)
for (index = 0; index < mbuf_count; index++) {
mbuf = __rte_mbuf_raw_alloc(vpool->pool);
- if (likely(MBUF_EXT_MEM(mbuf)))
+ if (likely(RTE_MBUF_INDIRECT(mbuf)))
pktmbuf_detach_zcp(mbuf);
rte_ring_sp_enqueue(vpool->ring, mbuf);
@@ -1653,7 +1651,7 @@ static void mbuf_destroy_zcp(struct vpool *vpool)
for (index = 0; index < mbuf_count; index++) {
mbuf = __rte_mbuf_raw_alloc(vpool->pool);
if (likely(mbuf != NULL)) {
- if (likely(MBUF_EXT_MEM(mbuf)))
+ if (likely(RTE_MBUF_INDIRECT(mbuf)))
pktmbuf_detach_zcp(mbuf);
rte_ring_sp_enqueue(vpool->ring, (void *)mbuf);
}
diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c
index 526b18d..e095999 100644
--- a/lib/librte_mbuf/rte_mbuf.c
+++ b/lib/librte_mbuf/rte_mbuf.c
@@ -125,6 +125,7 @@ rte_pktmbuf_init(struct rte_mempool *mp,
m->pool = mp;
m->nb_segs = 1;
m->port = 0xff;
+ m->priv_size = 0;
}
/* do some sanity checks on a mbuf: panic if it fails */
diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 17ba791..4ced6d3 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -268,7 +268,7 @@ struct rte_mbuf {
uint16_t data_len; /**< Amount of data in segment buffer. */
uint32_t pkt_len; /**< Total pkt len: sum of all segments. */
uint16_t vlan_tci; /**< VLAN Tag Control Identifier (CPU order) */
- uint16_t reserved;
+ uint16_t priv_size; /**< size of the application private data */
union {
uint32_t rss; /**< RSS hash result if RSS enabled */
struct {
@@ -320,15 +320,38 @@ struct rte_mbuf {
} __rte_cache_aligned;
/**
- * Given the buf_addr returns the pointer to corresponding mbuf.
+ * Return the mbuf owning the given data buffer address.
+ *
+ * @param mi
+ * The pointer to the indirect mbuf.
+ * @param buffer_addr
+ * The address of the data buffer of the direct mbuf.
+ * @return
+ * The address of the direct mbuf corresponding to buffer_addr.
*/
-#define RTE_MBUF_FROM_BADDR(ba) (((struct rte_mbuf *)(ba)) - 1)
+static inline struct rte_mbuf *
+rte_mbuf_from_baddr(struct rte_mbuf *mi, char *buffer_addr)
+{
+ struct rte_mbuf *md;
+ md = (struct rte_mbuf *)(buffer_addr - sizeof(*mi) - mi->priv_size);
+ return md;
+}
/**
- * Given the pointer to mbuf returns an address where it's buf_addr
- * should point to.
+ * Return the buffer address embedded in the given mbuf.
+ *
+ * @param md
+ * The pointer to the mbuf.
+ * @return
+ * The address of the data buffer owned by the mbuf.
*/
-#define RTE_MBUF_TO_BADDR(mb) (((struct rte_mbuf *)(mb)) + 1)
+static inline char *
+rte_mbuf_to_baddr(struct rte_mbuf *md)
+{
+ char *buffer_addr;
+ buffer_addr = (char *)md + sizeof(*md) + md->priv_size;
+ return buffer_addr;
+}
/**
* Returns TRUE if given mbuf is indirect, or FALSE otherwise.
@@ -744,9 +767,11 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *md)
static inline void rte_pktmbuf_detach(struct rte_mbuf *m)
{
const struct rte_mempool *mp = m->pool;
- void *buf = RTE_MBUF_TO_BADDR(m);
+ void *buf = rte_mbuf_to_baddr(m);
uint32_t buf_len = mp->elt_size - sizeof(*m);
- m->buf_physaddr = rte_mempool_virt2phy(mp, m) + sizeof (*m);
+
+ m->buf_physaddr = rte_mempool_virt2phy(mp, m) + sizeof (*m) +
+ m->priv_size;
m->buf_addr = buf;
m->buf_len = (uint16_t)buf_len;
@@ -774,7 +799,8 @@ __rte_pktmbuf_prefree_seg(struct rte_mbuf *m)
* - free attached mbuf segment
*/
if (RTE_MBUF_INDIRECT(m)) {
- struct rte_mbuf *md = RTE_MBUF_FROM_BADDR(m->buf_addr);
+ struct rte_mbuf *md =
+ rte_mbuf_from_baddr(m, (char *)m->buf_addr);
rte_pktmbuf_detach(m);
if (rte_mbuf_refcnt_update(md, -1) == 0)
__rte_mbuf_raw_free(md);
--
2.1.4