From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id 37ECA7EEF for ; Wed, 25 Mar 2015 18:00:46 +0100 (CET) Received: by wibg7 with SMTP id g7so117176328wib.1 for ; Wed, 25 Mar 2015 10:00:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=mzkYfO/FgDofnxNoNJh4sCDfCJUCekNN1az+5o8t2sA=; b=eXn4Qfq0GE4XyVOYAymn6U6ZxVu0iGbVhuyUkuc60xcI/HrM0VXtOH6Nxp44jUjJUz 1ixfgYczFnC/aO2jf9SH94sI1kSiNjNNrqT9UWxIu5uYktJusLUPr7nv1C32toXzyvVk 1uWobAqDuIvEAPmAMN9FkpywcbQNuvw8vbyYvHMWy/Wl75a1a8Fu7yPpqmc4dZba4Odl tsWqo3R2g+fWEwrBeQLP99A9IIBBDDZI71nl/kof0a2HHEVL7DUEY5oPUYQVfn1AqhnG H+PePJHOm5+ktT/Z6TYSChK6WaIyT0ekeevWVM104vkrhWg5QzGt0ffWkSAxE3ibcbw1 KHoQ== X-Gm-Message-State: ALoCoQkglLE61RsHymMfp0GHJsqt3Y4VMOPqV0vF5jOx8WoCcHO7GA46N6QQNGvvuq8MtgRlio2F X-Received: by 10.194.210.103 with SMTP id mt7mr20036111wjc.103.1427302845536; Wed, 25 Mar 2015 10:00:45 -0700 (PDT) Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id wo10sm4513373wjb.35.2015.03.25.10.00.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 25 Mar 2015 10:00:44 -0700 (PDT) From: Olivier Matz To: dev@dpdk.org Date: Wed, 25 Mar 2015 18:00:36 +0100 Message-Id: <1427302838-8285-4-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1427302838-8285-1-git-send-email-olivier.matz@6wind.com> References: <1427302838-8285-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH 3/5] test/mbuf: rename mc variable in m X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Mar 2015 17:00:46 -0000 It's better to name the mbuf 'm' instead of 'mc' as it's not a clone. Signed-off-by: Olivier Matz --- app/test/test_mbuf.c | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 1ff66cb..9a3cf8f 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -321,43 +321,42 @@ fail: static int testclone_testupdate_testdetach(void) { - struct rte_mbuf *mc = NULL; + struct rte_mbuf *m = NULL; struct rte_mbuf *clone = NULL; /* alloc a mbuf */ - - mc = rte_pktmbuf_alloc(pktmbuf_pool); - if (mc == NULL) + m = rte_pktmbuf_alloc(pktmbuf_pool); + if (m == NULL) GOTO_FAIL("ooops not allocating mbuf"); - if (rte_pktmbuf_pkt_len(mc) != 0) + if (rte_pktmbuf_pkt_len(m) != 0) GOTO_FAIL("Bad length"); /* clone the allocated mbuf */ - clone = rte_pktmbuf_clone(mc, pktmbuf_pool); + clone = rte_pktmbuf_clone(m, pktmbuf_pool); if (clone == NULL) GOTO_FAIL("cannot clone data\n"); rte_pktmbuf_free(clone); - mc->next = rte_pktmbuf_alloc(pktmbuf_pool); - if(mc->next == NULL) + m->next = rte_pktmbuf_alloc(pktmbuf_pool); + if (m->next == NULL) GOTO_FAIL("Next Pkt Null\n"); - clone = rte_pktmbuf_clone(mc, pktmbuf_pool); + clone = rte_pktmbuf_clone(m, pktmbuf_pool); if (clone == NULL) GOTO_FAIL("cannot clone data\n"); /* free mbuf */ - rte_pktmbuf_free(mc); + rte_pktmbuf_free(m); rte_pktmbuf_free(clone); - mc = NULL; + m = NULL; clone = NULL; return 0; fail: - if (mc) - rte_pktmbuf_free(mc); + if (m) + rte_pktmbuf_free(m); return -1; } #undef GOTO_FAIL -- 2.1.4