From: Michael Qiu <michael.qiu@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] vhost: Fix Segmentation fault of NULL address
Date: Thu, 26 Mar 2015 15:04:56 +0800 [thread overview]
Message-ID: <1427353496-21965-1-git-send-email-michael.qiu@intel.com> (raw)
Function gpa_to_vva() could return zero, while this will lead
a Segmentation fault.
This patch is to fix this issue.
Signed-off-by: Michael Qiu <michael.qiu@intel.com>
---
lib/librte_vhost/vhost_rxtx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_vhost/vhost_rxtx.c b/lib/librte_vhost/vhost_rxtx.c
index 535c7a1..23c8acb 100644
--- a/lib/librte_vhost/vhost_rxtx.c
+++ b/lib/librte_vhost/vhost_rxtx.c
@@ -587,6 +587,9 @@ rte_vhost_dequeue_burst(struct virtio_net *dev, uint16_t queue_id,
/* Buffer address translation. */
vb_addr = gpa_to_vva(dev, desc->addr);
+ if (!vb_addr)
+ return entry_success;
+
/* Prefetch buffer address. */
rte_prefetch0((void *)(uintptr_t)vb_addr);
--
1.9.3
next reply other threads:[~2015-03-26 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 7:04 Michael Qiu [this message]
2015-03-26 7:52 ` Xie, Huawei
2015-03-26 7:58 ` Qiu, Michael
2015-03-26 8:29 ` Linhaifeng
2015-03-27 8:45 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427353496-21965-1-git-send-email-michael.qiu@intel.com \
--to=michael.qiu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).