DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ravi Kerur <rkerur@gmail.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] Cleanup rte_memcpy.h
Date: Tue, 14 Apr 2015 14:30:11 -0700	[thread overview]
Message-ID: <1429047011-11545-1-git-send-email-rkerur@gmail.com> (raw)

rte_memcpy.h has
sperfluous type casting in several functions, remove those unnecessary casting.
while copying separate invocations of functions with changing offset, instead
offset can be calculated with loop.

Testing:
Compared code generated with and without changes with following gcc commands

gcc -O3 -m64 -S 

found no difference.

Tested on Ubuntu x86_64 (x86_64-native-linuxapp-gcc) with "make test"

Overall tests passed matches baseline.

Secondly memcpy performace tests take similar amount of time to finish.

/**********************With changes*************************************/
Start memcpy_perf:             Success                       [00m 00s]
Memcpy performance autotest:   Success                       [09m 36s] [17m 45s]
/**********************Without changes**********************************/
Start memcpy_perf:             Success                       [00m 00s]
Memcpy performance autotest:   Success                       [09m 35s] [13m 57s]

Ravi Kerur (1):
  Clean up rte_memcpy.h file

 .../common/include/arch/x86/rte_memcpy.h           | 317 ++++++++++-----------
 1 file changed, 151 insertions(+), 166 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-04-14 21:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 21:30 Ravi Kerur [this message]
2015-04-14 21:31 ` [dpdk-dev] [PATCH] Clean up rte_memcpy.h file Ravi Kerur
2015-04-15  2:53   ` Stephen Hemminger
2015-04-15 21:04     ` Ravi Kerur
2015-04-15  6:32   ` Pawel Wodkowski
2015-04-15 21:00     ` Ravi Kerur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1429047011-11545-1-git-send-email-rkerur@gmail.com \
    --to=rkerur@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).