From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com (mail-pa0-f41.google.com [209.85.220.41]) by dpdk.org (Postfix) with ESMTP id C2F75C348 for ; Tue, 14 Apr 2015 23:30:15 +0200 (CEST) Received: by pacyx8 with SMTP id yx8so25729514pac.1 for ; Tue, 14 Apr 2015 14:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=cXBEYU90QZdMSrtlITw31nRXUGSrvQI0GgB4hW9fGuc=; b=l32OA9Uy/Fu3CtlmfY6DLuvPFMGw7fUdgVQUb8/DWBPdXt3d5g4YRtFRzeFWO55xPW kdCcsiRINrToArvrS9HjhcSpfqyYj5w4nlGqZMsFGSzMUQvChWjs/i1HlVjN0Vvg8yRP efi3lcmwzGbGEF9OExjI1H2TuTMzOFU2BqP683TDKsHpNtrr++iMY9vpX/oFjE9Ftg5d Ni6lGmu3Y4jF5J1CVKzz74jOvTA0QsKXV7yS1izOJcitIuNMVzrHOTifkoOL66gCZsCc cLGx6LSfuidiQIP+X5q2hYQxzB2JXV1jJqx3KcoC9hDC7vQoBwS7tAJIU1GEiR2vV8GS O1UA== X-Received: by 10.70.42.104 with SMTP id n8mr34135348pdl.88.1429047015206; Tue, 14 Apr 2015 14:30:15 -0700 (PDT) Received: from user-PC.hsd1.ca.comcast.net (c-98-234-176-9.hsd1.ca.comcast.net. [98.234.176.9]) by mx.google.com with ESMTPSA id op4sm1982096pbb.77.2015.04.14.14.30.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Apr 2015 14:30:14 -0700 (PDT) From: Ravi Kerur To: dev@dpdk.org Date: Tue, 14 Apr 2015 14:30:11 -0700 Message-Id: <1429047011-11545-1-git-send-email-rkerur@gmail.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] Cleanup rte_memcpy.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 21:30:16 -0000 rte_memcpy.h has sperfluous type casting in several functions, remove those unnecessary casting. while copying separate invocations of functions with changing offset, instead offset can be calculated with loop. Testing: Compared code generated with and without changes with following gcc commands gcc -O3 -m64 -S found no difference. Tested on Ubuntu x86_64 (x86_64-native-linuxapp-gcc) with "make test" Overall tests passed matches baseline. Secondly memcpy performace tests take similar amount of time to finish. /**********************With changes*************************************/ Start memcpy_perf: Success [00m 00s] Memcpy performance autotest: Success [09m 36s] [17m 45s] /**********************Without changes**********************************/ Start memcpy_perf: Success [00m 00s] Memcpy performance autotest: Success [09m 35s] [13m 57s] Ravi Kerur (1): Clean up rte_memcpy.h file .../common/include/arch/x86/rte_memcpy.h | 317 ++++++++++----------- 1 file changed, 151 insertions(+), 166 deletions(-) -- 1.9.1