From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f44.google.com (mail-pa0-f44.google.com [209.85.220.44]) by dpdk.org (Postfix) with ESMTP id 41915376C for ; Wed, 15 Apr 2015 17:20:17 +0200 (CEST) Received: by pabsx10 with SMTP id sx10so54271264pab.3 for ; Wed, 15 Apr 2015 08:20:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HGa6/QdzeuufkO+z9m7l4rsG0m+z5RuFoGDUeJmq1Qc=; b=jvLQKn3myzFbucOylpki2RkWz3yR8CRUvMsUKNDAobvEc3U16k1qgMWzBcV+5Vfynj /EZY9dfhCLF4AFA9OHLfKJmoYf944vNSMYi6L00ZiC6TNpiFYhM7qeMb2OgLbtNDUPh+ qDc4MGZG3cNdOQh0kDEkYEUXv6hxzcJ56oWebY8uaVQeKn7S+QNG21Xi/XXJ1AoUSFjA zFmPo+V9ZckRhkYp690AxNASy0hd9QrBSqmIndwuvTp3lr2ritbXh2+JgjXb9uDxjD3T ALfl2y2Ekwp5jy1BDtj66A37HibAHtwFgcriJjlyG87DET75ebSz8dChiOQvsTHeuWGD 0w1w== X-Gm-Message-State: ALoCoQnkWMomZeHjG4SBcLrHAHvx7JkhITasGHNN/nW7ENnH9sOh98n4Tq0Oi7LDPv7LJvYLl+az X-Received: by 10.66.124.164 with SMTP id mj4mr48170770pab.83.1429111216685; Wed, 15 Apr 2015 08:20:16 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id sm7sm4459057pac.45.2015.04.15.08.20.15 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Apr 2015 08:20:15 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Date: Wed, 15 Apr 2015 08:20:15 -0700 Message-Id: <1429111219-8789-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1429111219-8789-1-git-send-email-stephen@networkplumber.org> References: <1429111219-8789-1-git-send-email-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/5] virtio: remove useless new lines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2015 15:20:17 -0000 There are several places in virtio with extra newlines between calling a function and checking the result. Remove them to improve readability. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_virtio/virtio_ethdev.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c b/lib/librte_pmd_virtio/virtio_ethdev.c index ffa26a0..a38ceed 100644 --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -228,7 +228,6 @@ virtio_set_multiple_queues(struct rte_eth_dev *dev, uint16_t nb_queues) dlen[0] = sizeof(uint16_t); ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) { PMD_INIT_LOG(ERR, "Multiqueue configured but send command " "failed, this is too late now..."); @@ -394,7 +393,6 @@ virtio_dev_cq_queue_setup(struct rte_eth_dev *dev, uint16_t vtpci_queue_idx, PMD_INIT_FUNC_TRACE(); ret = virtio_dev_queue_setup(dev, VTNET_CQ, VTNET_SQ_CQ_QUEUE_IDX, vtpci_queue_idx, nb_desc, socket_id, &vq); - if (ret < 0) { PMD_INIT_LOG(ERR, "control vq initialization failed"); return ret; @@ -434,7 +432,6 @@ virtio_dev_promiscuous_enable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to enable promisc"); } @@ -453,7 +450,6 @@ virtio_dev_promiscuous_disable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to disable promisc"); } @@ -472,7 +468,6 @@ virtio_dev_allmulticast_enable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to enable allmulticast"); } @@ -491,7 +486,6 @@ virtio_dev_allmulticast_disable(struct rte_eth_dev *dev) dlen[0] = 1; ret = virtio_send_command(hw->cvq, &ctrl, dlen, 1); - if (ret) PMD_INIT_LOG(ERR, "Failed to disable allmulticast"); } -- 2.1.4