From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void
Date: Fri, 17 Apr 2015 08:35:33 -0700 [thread overview]
Message-ID: <1429284934-3261-2-git-send-email-stephen@networkplumber.org> (raw)
In-Reply-To: <1429284934-3261-1-git-send-email-stephen@networkplumber.org>
Function always returned 0 and no one was checking anyway.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_eal/common/eal_common_log.c | 3 +--
lib/librte_eal/common/include/rte_log.h | 5 +----
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c
index ff44d23..3802f9c 100644
--- a/lib/librte_eal/common/eal_common_log.c
+++ b/lib/librte_eal/common/eal_common_log.c
@@ -158,14 +158,13 @@ rte_log_set_history(int enable)
}
/* Change the stream that will be used by logging system */
-int
+void
rte_openlog_stream(FILE *f)
{
if (f == NULL)
rte_logs.file = default_log_stream;
else
rte_logs.file = f;
- return 0;
}
/* Set global log level */
diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h
index f83a0d9..888ee19 100644
--- a/lib/librte_eal/common/include/rte_log.h
+++ b/lib/librte_eal/common/include/rte_log.h
@@ -110,11 +110,8 @@ extern FILE *eal_default_log_stream;
*
* @param f
* Pointer to the stream.
- * @return
- * - 0 on success.
- * - Negative on error.
*/
-int rte_openlog_stream(FILE *f);
+void rte_openlog_stream(FILE *f);
/**
* Set the global log level.
--
2.1.4
next prev parent reply other threads:[~2015-04-17 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 15:35 [dpdk-dev] [PATCH 0/2] functions with useless return Stephen Hemminger
2015-04-17 15:35 ` Stephen Hemminger [this message]
2015-05-19 10:24 ` [dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void Bruce Richardson
2015-07-30 0:35 ` Stephen Hemminger
2015-04-17 15:35 ` [dpdk-dev] [PATCH 2/2] eal: pci probe and adjust_config " Stephen Hemminger
2015-04-20 13:14 ` Thomas Monjalon
2015-04-17 15:53 ` [dpdk-dev] [PATCH 0/2] functions with useless return Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429284934-3261-2-git-send-email-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).