From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f179.google.com (mail-pd0-f179.google.com [209.85.192.179]) by dpdk.org (Postfix) with ESMTP id AA7C4C2FC for ; Fri, 17 Apr 2015 17:35:32 +0200 (CEST) Received: by pdbnk13 with SMTP id nk13so131552938pdb.0 for ; Fri, 17 Apr 2015 08:35:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qBTzo9SsqrX9noIzFF9kQl0keuT6Wmu7emyzjcIuOqE=; b=bETRl86/jWVHBMQGu2BboRRoNmkzczYNx0T7k3KcbZpvfwLx9vv+3VAJJTvmkAbddp iW3Nz85AnCEV7hdPj51Vv00CkjQgniO6ArMMD0RooL4Jgv1c3zNCz7hrg8awjWwy856A zr7uw//ulbqxqPQKvkx+Wzf0rL54VlpJBitAtZ9TE9Y+ilo1t9c3/9o/BE+4x9oy970y aI3/sdJfqPN7Qy1gFLswuPQtdqHwvIysfZdtKeyLdXQbiqmMmgnO5gs35TqbQuNmajUu w7+9/enDQTNM1jNaZOB5W65Ji4kyRLCIhh/w9cvl9Mx25lkm3y8aQi7F3UDPyMW91Mtw qbew== X-Gm-Message-State: ALoCoQkN3W8c3XRHAVY9i+uctrhBbd1s9O603WNHISIFGvPHmLcex8PX2viMBn9UcQcdiAfHnlzq X-Received: by 10.70.131.107 with SMTP id ol11mr6510546pdb.63.1429284932091; Fri, 17 Apr 2015 08:35:32 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id dc5sm10460175pbc.53.2015.04.17.08.35.31 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Apr 2015 08:35:31 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Date: Fri, 17 Apr 2015 08:35:33 -0700 Message-Id: <1429284934-3261-2-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1429284934-3261-1-git-send-email-stephen@networkplumber.org> References: <1429284934-3261-1-git-send-email-stephen@networkplumber.org> Subject: [dpdk-dev] [PATCH 1/2] log: rte_openlog_stream should be void X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2015 15:35:33 -0000 Function always returned 0 and no one was checking anyway. Signed-off-by: Stephen Hemminger --- lib/librte_eal/common/eal_common_log.c | 3 +-- lib/librte_eal/common/include/rte_log.h | 5 +---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c index ff44d23..3802f9c 100644 --- a/lib/librte_eal/common/eal_common_log.c +++ b/lib/librte_eal/common/eal_common_log.c @@ -158,14 +158,13 @@ rte_log_set_history(int enable) } /* Change the stream that will be used by logging system */ -int +void rte_openlog_stream(FILE *f) { if (f == NULL) rte_logs.file = default_log_stream; else rte_logs.file = f; - return 0; } /* Set global log level */ diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h index f83a0d9..888ee19 100644 --- a/lib/librte_eal/common/include/rte_log.h +++ b/lib/librte_eal/common/include/rte_log.h @@ -110,11 +110,8 @@ extern FILE *eal_default_log_stream; * * @param f * Pointer to the stream. - * @return - * - 0 on success. - * - Negative on error. */ -int rte_openlog_stream(FILE *f); +void rte_openlog_stream(FILE *f); /** * Set the global log level. -- 2.1.4