From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id F2EF7C3CE for ; Sat, 18 Apr 2015 21:34:00 +0200 (CEST) Received: by pdea3 with SMTP id a3so163182226pde.3 for ; Sat, 18 Apr 2015 12:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VCya/zeRLD+YSl9Z0ONuZabTebgDuEymxDeE5IGo+VA=; b=lcZ11JELevBS+coOmeLPfY1I07wFmIY1bFr2OWzoT/cGPcfI8c59SafTxMLmnV7m5F 3x2WK6HRPz+BcBDY88/fLuHLu9tRyUVkQ0fBSRWGrjGAuJRCmmlxwBshuMBvQhvYFgdN 3insOPsTFQOMl59FBp8A8d1fHCHjYlEIpvvQK2bI1QygdcB4AirFrYRv0Oj0QVsJRnjy Vl73dXj37Xwbq8LShbKN9cAuat+RBKxcW6ImPU4gVGKPD8r4WnjQX3nHHrZ4b7DjjEJE IgJjMmOecGF+Cg6azkaqX+Q3+NaFKSsAVmtG2BKCvCZR8+Tb15AsuXaRP0M7ZlCa6Px6 b6FA== X-Received: by 10.66.145.2 with SMTP id sq2mr15604150pab.124.1429385640430; Sat, 18 Apr 2015 12:34:00 -0700 (PDT) Received: from user-PC.hsd1.ca.comcast.net (c-98-234-176-9.hsd1.ca.comcast.net. [98.234.176.9]) by mx.google.com with ESMTPSA id ul8sm13722397pab.36.2015.04.18.12.33.59 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Apr 2015 12:33:59 -0700 (PDT) From: Ravi Kerur To: dev@dpdk.org Date: Sat, 18 Apr 2015 12:33:50 -0700 Message-Id: <1429385631-12277-5-git-send-email-rkerur@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1429385631-12277-1-git-send-email-rkerur@gmail.com> References: <1429385571-12218-1-git-send-email-rkerur@gmail.com> <1429385631-12277-1-git-send-email-rkerur@gmail.com> Subject: [dpdk-dev] [PATCH v6 5/9] Move common functions in eal_memory.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Apr 2015 19:34:01 -0000 Changes in v6 Removed unnecessary comments in function declaration. Changes in v5 Rebase to latest code. Changes in v4 Make rte_eal_hugepage_init and rte_eal_hugepage_attach as wrapper functions for BSD. Changes in v3 Changed subject to be more explicit on file name inclusion. Changes in v2 Use common function names rte_eal_hugepage_init and rte_eal_hugepage_attach for BSD and Linux. Update comments about its actuality in function declaration. Changes in v1 Move common functions in eal_memory.c to librte_eal/common/ eal_common_memory.c file. Following functions are moved to eal_common_memory.c file static int rte_eal_memdevice_init(void); int rte_eal_memory_init(void); Fix checkpatch warnings and errors. Signed-off-by: Ravi Kerur --- lib/librte_eal/bsdapp/eal/eal_memory.c | 47 +++++++++++-------------------- lib/librte_eal/common/eal_common_memory.c | 38 +++++++++++++++++++++++-- lib/librte_eal/common/eal_private.h | 20 +++++++++++-- lib/librte_eal/linuxapp/eal/eal_memory.c | 36 ++--------------------- 4 files changed, 72 insertions(+), 69 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_memory.c b/lib/librte_eal/bsdapp/eal/eal_memory.c index 33ebd0f..77c27b3 100644 --- a/lib/librte_eal/bsdapp/eal/eal_memory.c +++ b/lib/librte_eal/bsdapp/eal/eal_memory.c @@ -59,7 +59,7 @@ rte_mem_virt2phy(const void *virtaddr) return RTE_BAD_PHYS_ADDR; } -static int +static inline int rte_eal_contigmem_init(void) { struct rte_mem_config *mcfg; @@ -131,7 +131,16 @@ rte_eal_contigmem_init(void) return 0; } -static int +/* + * Wrapper function to initialize contigmem. + */ +int +rte_eal_hugepage_init(void) +{ + return rte_eal_contigmem_init(); +} + +static inline int rte_eal_contigmem_attach(void) { const struct hugepage_info *hpi; @@ -192,35 +201,11 @@ error: return -1; } - -static int -rte_eal_memdevice_init(void) -{ - struct rte_config *config; - - if (rte_eal_process_type() == RTE_PROC_SECONDARY) - return 0; - - config = rte_eal_get_configuration(); - config->mem_config->nchannel = internal_config.force_nchannel; - config->mem_config->nrank = internal_config.force_nrank; - - return 0; -} - -/* init memory subsystem */ +/* + * Wrapper function to attach contigmem. + */ int -rte_eal_memory_init(void) +rte_eal_hugepage_attach(void) { - RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n"); - const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ? - rte_eal_contigmem_init() : - rte_eal_contigmem_attach(); - if (retval < 0) - return -1; - - if (internal_config.no_shconf == 0 && rte_eal_memdevice_init() < 0) - return -1; - - return 0; + return rte_eal_contigmem_attach(); } diff --git a/lib/librte_eal/common/eal_common_memory.c b/lib/librte_eal/common/eal_common_memory.c index 9a07b1e..10ff0bc 100644 --- a/lib/librte_eal/common/eal_common_memory.c +++ b/lib/librte_eal/common/eal_common_memory.c @@ -45,6 +45,7 @@ #include #include "eal_private.h" +#include "eal_internal_cfg.h" /* * Return a pointer to a read-only table of struct rte_physmem_desc @@ -69,7 +70,7 @@ rte_eal_get_physmem_size(void) /* get pointer to global configuration */ mcfg = rte_eal_get_configuration()->mem_config; - for (i=0; imemseg[i].addr == NULL) break; @@ -89,7 +90,7 @@ rte_dump_physmem_layout(FILE *f) /* get pointer to global configuration */ mcfg = rte_eal_get_configuration()->mem_config; - for (i=0; imemseg[i].addr == NULL) break; @@ -118,3 +119,36 @@ unsigned rte_memory_get_nrank(void) { return rte_eal_get_configuration()->mem_config->nrank; } + +static int +rte_eal_memdevice_init(void) +{ + struct rte_config *config; + + if (rte_eal_process_type() == RTE_PROC_SECONDARY) + return 0; + + config = rte_eal_get_configuration(); + config->mem_config->nchannel = internal_config.force_nchannel; + config->mem_config->nrank = internal_config.force_nrank; + + return 0; +} + +/* init memory subsystem */ +int +rte_eal_memory_init(void) +{ + RTE_LOG(INFO, EAL, "Setting up physically contiguous memory...\n"); + const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ? + rte_eal_hugepage_init() : + rte_eal_hugepage_attach(); + + if (retval < 0) + return -1; + + if (internal_config.no_shconf == 0 && rte_eal_memdevice_init() < 0) + return -1; + + return 0; +} diff --git a/lib/librte_eal/common/eal_private.h b/lib/librte_eal/common/eal_private.h index 0311638..5fd9b50 100644 --- a/lib/librte_eal/common/eal_private.h +++ b/lib/librte_eal/common/eal_private.h @@ -334,8 +334,6 @@ void set_tsc_freq(void); /** * This function sets TSC frequency from sysctl * for BSD and from clock for Linux. - * Is a wrapper function for BSD which will - * internally call set_tsc_freq_from_sysctl. * * This function is private to the EAL. */ @@ -348,4 +346,22 @@ int set_tsc_freq_from_clock(void); */ void rte_set_tsc_hz(uint64_t tsc_hz); +/** + * This function prepares physical memory mapping + * i.e. hugepages on Linux and + * contigmem on BSD. + * + * This function is private to the EAL. + */ +int rte_eal_hugepage_init(void); + +/** + * This function creates memory mapping in secondary + * i.e. hugepages on Linux and + * contigmem on BSD. + * + * This function is private to the EAL. + */ +int rte_eal_hugepage_attach(void); + #endif /* _EAL_PRIVATE_H_ */ diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c index 5f9f92e..c83a2cb 100644 --- a/lib/librte_eal/linuxapp/eal/eal_memory.c +++ b/lib/librte_eal/linuxapp/eal/eal_memory.c @@ -1030,7 +1030,7 @@ calc_num_pages_per_socket(uint64_t * memory, * 6. unmap the first mapping * 7. fill memsegs in configuration with contiguous zones */ -static int +int rte_eal_hugepage_init(void) { struct rte_mem_config *mcfg; @@ -1368,7 +1368,7 @@ getFileSize(int fd) * configuration and finds the hugepages which form that segment, mapping them * in order to form a contiguous block in the virtual memory space */ -static int +int rte_eal_hugepage_attach(void) { const struct rte_mem_config *mcfg = rte_eal_get_configuration()->mem_config; @@ -1529,35 +1529,3 @@ error: return -1; } -static int -rte_eal_memdevice_init(void) -{ - struct rte_config *config; - - if (rte_eal_process_type() == RTE_PROC_SECONDARY) - return 0; - - config = rte_eal_get_configuration(); - config->mem_config->nchannel = internal_config.force_nchannel; - config->mem_config->nrank = internal_config.force_nrank; - - return 0; -} - - -/* init memory subsystem */ -int -rte_eal_memory_init(void) -{ - RTE_LOG(INFO, EAL, "Setting up memory...\n"); - const int retval = rte_eal_process_type() == RTE_PROC_PRIMARY ? - rte_eal_hugepage_init() : - rte_eal_hugepage_attach(); - if (retval < 0) - return -1; - - if (internal_config.no_shconf == 0 && rte_eal_memdevice_init() < 0) - return -1; - - return 0; -} -- 1.9.1