From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f173.google.com (mail-pd0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id AED1368A5 for ; Mon, 20 Apr 2015 21:26:33 +0200 (CEST) Received: by pdbqa5 with SMTP id qa5so216710186pdb.1 for ; Mon, 20 Apr 2015 12:26:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qVl1w/rwS0DE0/8ZtVfrAskZy+ozB7IomicVc3Pq2Zc=; b=EAmS4IxinfFuAJnLK/OO9fv2kY7mrGxSVPhUXfa5x+TkAcIpOsTeXaUOMWY80AszlT dDd+rGVUQzW4FOHt6JU7vafV1cYJMdhxwS0V6G5b0enD41SwixL7b0zffa8YuuUydBo2 OwdRuOj8ZPznxtnIpXX7gDtQ30eQv8QMIXyTp0D1BuaNT9o8otVHM6YQj5oa+UijUj2D yPPUzkfW7GtQxx7EcXgn1YbmhpdavWFicn5mFStc+jLZM05nfsLOSmTlM3gildjR0+fD h/cv9NKcQfP3bCs+Uy4hQeuAPKZIX8757jlqLXrT18HgoasDOnuPwtTIurECzQ057zBj 5pLQ== X-Received: by 10.66.240.34 with SMTP id vx2mr31015008pac.136.1429557993158; Mon, 20 Apr 2015 12:26:33 -0700 (PDT) Received: from buildhost2.vyatta.com. ([144.49.132.22]) by mx.google.com with ESMTPSA id eo5sm18899418pbb.51.2015.04.20.12.26.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Apr 2015 12:26:31 -0700 (PDT) From: Eric Kinzie To: dev@dpdk.org Date: Mon, 20 Apr 2015 12:26:14 -0700 Message-Id: <1429557976-13531-3-git-send-email-ehkinzie@gmail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1429557976-13531-1-git-send-email-ehkinzie@gmail.com> References: <1429557976-13531-1-git-send-email-ehkinzie@gmail.com> Cc: Eric Kinzie Subject: [dpdk-dev] [PATCH v2 2/4] bond mode 4: do not ignore multicast X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2015 19:26:34 -0000 From: Eric Kinzie The bonding PMD in mode 4 puts all enslaved interfaces into promiscuous mode in order to receive LACPDUs and must filter unwanted packets after the traffic has been "collected". Allow broadcast and multicast through so that ARP and IPv6 neighbor discovery continue to work. Fixes: 46fb43683679 ("bond: add mode 4") Signed-off-by: Eric Kinzie --- app/test/test_link_bonding_mode4.c | 7 +++++-- lib/librte_pmd_bond/rte_eth_bond_pmd.c | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/app/test/test_link_bonding_mode4.c b/app/test/test_link_bonding_mode4.c index 02380f9..5a726af 100644 --- a/app/test/test_link_bonding_mode4.c +++ b/app/test/test_link_bonding_mode4.c @@ -755,8 +755,11 @@ test_mode4_rx(void) rte_eth_macaddr_get(test_params.bonded_port_id, &bonded_mac); ether_addr_copy(&bonded_mac, &dst_mac); - /* Assert that dst address is not bonding address */ - dst_mac.addr_bytes[0]++; + /* Assert that dst address is not bonding address. Do not set the + * least significant bit of the zero byte as this would create a + * multicast address. + */ + dst_mac.addr_bytes[0] += 2; /* First try with promiscuous mode enabled. * Add 2 packets to each slave. First with bonding MAC address, second with diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c b/lib/librte_pmd_bond/rte_eth_bond_pmd.c index c937e6b..1691300 100644 --- a/lib/librte_pmd_bond/rte_eth_bond_pmd.c +++ b/lib/librte_pmd_bond/rte_eth_bond_pmd.c @@ -170,6 +170,7 @@ bond_ethdev_rx_burst_8023ad(void *queue, struct rte_mbuf **bufs, * mode and packet address does not match. */ if (unlikely(hdr->ether_type == ether_type_slow_be || !collecting || (!promisc && + !is_multicast_ether_addr(&hdr->d_addr) && !is_same_ether_addr(&bond_mac, &hdr->d_addr)))) { if (hdr->ether_type == ether_type_slow_be) { -- 1.7.10.4