From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <olivier.matz@6wind.com> Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 04B496A80 for <dev@dpdk.org>; Wed, 22 Apr 2015 11:57:44 +0200 (CEST) Received: by wgin8 with SMTP id n8so240380326wgi.0 for <dev@dpdk.org>; Wed, 22 Apr 2015 02:57:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BfEWiurwTKSNKMfrZ4IfNCJCbcgm++P61+Dml1EBqkw=; b=agFxsSJ7CzrK2fI8b02S05En9XqKOOIQLEiua2aI6C+rCixVsiWfvjS1q4O4skQZwW jSKXHMBdxTS6qXoPlKX+sceb5CCzNhePuM+sMqiz61YOYuk1tO85b6LP6Dqqc+S86Tgs zYFkx39Ru7vISeI2y47JkurKq0rHn3+3/K1w6gMUZiee34CbKbu5372FQnbl17kdF5th 1mrK3CF7dYDBRg89j429qsFopn6Ekw6tO6QWnvWKbmS8ChuIO2kzYMmKpdwCdxJYzq9H hghJif9tyAYj8lPHaIDwJ4hSM1x/k6+awRy33/+z5TrFqPwFCP/j9DnTSXJrQ/Hvp4HR CYsw== X-Gm-Message-State: ALoCoQmd2ilWtg1z+h2ui9UjVxRmesgJ43grLSUHW2UNQD64tkyI1pYHahtiHHQh/e1/92JJ2rJC X-Received: by 10.194.23.66 with SMTP id k2mr10732045wjf.18.1429696663637; Wed, 22 Apr 2015 02:57:43 -0700 (PDT) Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id yr1sm6570006wjc.37.2015.04.22.02.57.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Apr 2015 02:57:42 -0700 (PDT) From: Olivier Matz <olivier.matz@6wind.com> To: dev@dpdk.org Date: Wed, 22 Apr 2015 11:57:17 +0200 Message-Id: <1429696650-9043-1-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1429610122-30943-1-git-send-email-olivier.matz@6wind.com> References: <1429610122-30943-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH v6 00/13] mbuf: enhancements of mbuf clones X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 22 Apr 2015 09:57:44 -0000 The first objective of this series is to fix the support of indirect mbufs when the application reserves a private area in mbufs. It also removes the limitation that rte_pktmbuf_clone() is only allowed on direct (non-cloned) mbufs. The series also contains some enhancements and fixes in the mbuf area that makes the implementation of the last patches easier. Changes in v6: - restore the priv_size in mbuf structure, version 4 broke the attachment between mbufs having different private size - add a test case to ensure it won't be broken again - replace 0xffff by UINT16_MAX - fix some minor checkpatch issues Changes in v5: - update rte_mbuf_version.map to fix compilation with shared libraries Changes in v4: - do not add a priv_size in mbuf structure, having a proper accessor to read it from the pool private area is clearer - prepend some reworks in the mbuf area to simplify the implementation (fix mbuf initialization by not using a hardcoded mbuf size, add accessors for mbuf pool private area, add a helper to create a mbuf pool) Changes in v3: - a mbuf can now attach to another one that have a different private size. In this case, the m->priv_size corresponds to the size of the private area of the direct mbuf. - add comments to reflect these changes - minor style modifications Changes in v2: - do not change the use of MBUF_EXT_MEM() in vhost - change rte_mbuf_from_baddr() to rte_mbuf_from_indirect(), removing one parameter - fix and rework rte_pktmbuf_detach() - move m->priv_size in second mbuf cache line - fix mbuf free in test error case Olivier Matz (13): mbuf: fix mbuf data room size calculation rte_pktmbuf_pool_init examples: always initialize mbuf_pool private area mbuf: add accessors to get data room size and private size mbuf: fix rte_pktmbuf_init when mbuf private size is not zero testpmd: use standard functions to initialize mbufs and mbuf pool mbuf: introduce a new helper to create a mbuf pool apps: use rte_pktmbuf_pool_create to create mbuf pools mbuf: fix clone support when application uses private mbuf data mbuf: allow to clone an indirect mbuf test/mbuf: rename mc variable in m test/mbuf: enhance mbuf refcnt test test/mbuf: verify that cloning a clone works properly test/mbuf: add a test case for clone with different priv size app/test-pipeline/init.c | 15 +- app/test-pmd/testpmd.c | 84 +------- app/test/test_distributor.c | 10 +- app/test/test_distributor_perf.c | 10 +- app/test/test_kni.c | 16 +- app/test/test_link_bonding.c | 10 +- app/test/test_link_bonding_mode4.c | 12 +- app/test/test_mbuf.c | 238 ++++++++++++++++++--- app/test/test_pmd_perf.c | 11 +- app/test/test_pmd_ring.c | 10 +- app/test/test_reorder.c | 10 +- app/test/test_sched.c | 16 +- app/test/test_table.c | 9 +- app/test/test_table.h | 3 +- doc/guides/rel_notes/updating_apps.rst | 16 ++ examples/bond/main.c | 10 +- examples/distributor/main.c | 11 +- examples/dpdk_qat/main.c | 10 +- examples/exception_path/main.c | 14 +- examples/ip_fragmentation/main.c | 18 +- examples/ip_pipeline/init.c | 28 +-- examples/ipv4_multicast/main.c | 21 +- examples/kni/main.c | 12 +- examples/l2fwd-ivshmem/host/host.c | 10 +- examples/l2fwd-jobstats/main.c | 10 +- examples/l2fwd/main.c | 11 +- examples/l3fwd-acl/main.c | 11 +- examples/l3fwd-power/main.c | 11 +- examples/l3fwd-vf/main.c | 12 +- examples/l3fwd/main.c | 10 +- examples/link_status_interrupt/main.c | 10 +- examples/load_balancer/init.c | 12 +- examples/load_balancer/main.h | 4 +- .../client_server_mp/mp_server/init.c | 10 +- examples/multi_process/symmetric_mp/main.c | 10 +- examples/netmap_compat/bridge/bridge.c | 12 +- examples/packet_ordering/main.c | 11 +- examples/qos_meter/main.c | 7 +- examples/qos_sched/init.c | 10 +- examples/qos_sched/main.h | 2 +- examples/quota_watermark/include/conf.h | 2 +- examples/quota_watermark/qw/main.c | 7 +- examples/rxtx_callbacks/main.c | 11 +- examples/skeleton/basicfwd.c | 13 +- examples/vhost/main.c | 31 +-- examples/vhost_xen/main.c | 11 +- examples/vmdq/main.c | 11 +- examples/vmdq_dcb/main.c | 10 +- lib/librte_ether/rte_ethdev.c | 4 +- lib/librte_mbuf/rte_mbuf.c | 65 ++++-- lib/librte_mbuf/rte_mbuf.h | 200 +++++++++++++---- lib/librte_mbuf/rte_mbuf_version.map | 8 + lib/librte_pmd_af_packet/rte_eth_af_packet.c | 6 +- lib/librte_pmd_bond/rte_eth_bond_alb.c | 16 +- lib/librte_pmd_e1000/em_rxtx.c | 5 +- lib/librte_pmd_e1000/igb_rxtx.c | 12 +- lib/librte_pmd_fm10k/fm10k_ethdev.c | 6 +- lib/librte_pmd_i40e/i40e_ethdev_vf.c | 6 +- lib/librte_pmd_i40e/i40e_rxtx.c | 15 +- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 12 +- lib/librte_pmd_pcap/rte_eth_pcap.c | 5 +- lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 7 +- 62 files changed, 650 insertions(+), 570 deletions(-) -- 2.1.4