From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by dpdk.org (Postfix) with ESMTP id D6A116A80 for ; Wed, 22 Apr 2015 11:57:45 +0200 (CEST) Received: by wiax7 with SMTP id x7so126202318wia.0 for ; Wed, 22 Apr 2015 02:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=p5qJw/eoNZ+XibgerBvSKcpDeBTYcr3zqt19GcoHg8E=; b=FQs1szNObv1O0zCO4uu0qfdSpuNqahM/jQ4FLp13qAjLfs5mmieEIFAR09BiiDaZB4 2hFIhFh0ebASgm6aAlBhP2b4CGlqU4XdlkNMyPaztpxxWi05tTFZz7sdIw4891FhbWzD nDO26RaKkra/LcGZxAB9QDto0KW9HoaCGMGSUW1zugdaZGg/WXR1fjvXpemCBaeVBX0n 0XbTotei7XHmFO0LTgFw4JqXtVT8j0Ji5ut2thUv2fZmuaX3W7yoXyBsgr3OkFv49BWC tjyu5YF4s9a59XgAbXjXofOeiK2pF6LRwtQGZAmpYMHhOVHMbrSh/Ow+YIMamw/aCr9c +RVQ== X-Gm-Message-State: ALoCoQlpjAVmi3/mIBeYdgrBPplVXlM6gD3v9/lbg4seVRiEnxFZ6bwMF7x84N5cQvvHY/Lg3Ojz X-Received: by 10.180.90.230 with SMTP id bz6mr4258439wib.79.1429696665724; Wed, 22 Apr 2015 02:57:45 -0700 (PDT) Received: from glumotte.dev.6wind.com (6wind.net2.nerim.net. [213.41.180.237]) by mx.google.com with ESMTPSA id yr1sm6570006wjc.37.2015.04.22.02.57.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 22 Apr 2015 02:57:45 -0700 (PDT) From: Olivier Matz To: dev@dpdk.org Date: Wed, 22 Apr 2015 11:57:19 +0200 Message-Id: <1429696650-9043-3-git-send-email-olivier.matz@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1429696650-9043-1-git-send-email-olivier.matz@6wind.com> References: <1429610122-30943-1-git-send-email-olivier.matz@6wind.com> <1429696650-9043-1-git-send-email-olivier.matz@6wind.com> Subject: [dpdk-dev] [PATCH v6 02/13] examples: always initialize mbuf_pool private area X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2015 09:57:46 -0000 The mbuf pool private area must always be populated in a mbuf pool. The applications or drivers may expect that for a mbuf pool, the mbuf pool private area (mbuf_data_room_size and mbuf_priv_size) are properly filled. Signed-off-by: Olivier Matz Acked-by: Neil Horman --- examples/ip_fragmentation/main.c | 4 ++-- examples/ip_pipeline/init.c | 8 ++++++-- examples/ipv4_multicast/main.c | 6 ++++-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c index 93ea2a1..cf63718 100644 --- a/examples/ip_fragmentation/main.c +++ b/examples/ip_fragmentation/main.c @@ -764,8 +764,8 @@ init_mem(void) mp = rte_mempool_create(buf, NB_MBUF, sizeof(struct rte_mbuf), 32, - 0, - NULL, NULL, + sizeof(struct rte_pktmbuf_pool_private), + rte_pktmbuf_pool_init, NULL, rte_pktmbuf_init, NULL, socket, 0); if (mp == NULL) { diff --git a/examples/ip_pipeline/init.c b/examples/ip_pipeline/init.c index 96aee2b..61d71c3 100644 --- a/examples/ip_pipeline/init.c +++ b/examples/ip_pipeline/init.c @@ -363,6 +363,8 @@ app_get_ring_resp(uint32_t core_id) static void app_init_mbuf_pools(void) { + struct rte_pktmbuf_pool_private indirect_mbp_priv; + /* Init the buffer pool */ RTE_LOG(INFO, USER1, "Creating the mbuf pool ...\n"); app.pool = rte_mempool_create( @@ -380,13 +382,15 @@ app_init_mbuf_pools(void) /* Init the indirect buffer pool */ RTE_LOG(INFO, USER1, "Creating the indirect mbuf pool ...\n"); + indirect_mbp_priv.mbuf_data_room_size = 0; + indirect_mbp_priv.mbuf_priv_size = sizeof(struct app_pkt_metadata); app.indirect_pool = rte_mempool_create( "indirect mempool", app.pool_size, sizeof(struct rte_mbuf) + sizeof(struct app_pkt_metadata), app.pool_cache_size, - 0, - NULL, NULL, + sizeof(struct rte_pktmbuf_pool_private), + rte_pktmbuf_pool_init, &indirect_mbp_priv, rte_pktmbuf_init, NULL, rte_socket_id(), 0); diff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c index eed5611..19832d8 100644 --- a/examples/ipv4_multicast/main.c +++ b/examples/ipv4_multicast/main.c @@ -699,14 +699,16 @@ main(int argc, char **argv) rte_exit(EXIT_FAILURE, "Cannot init packet mbuf pool\n"); header_pool = rte_mempool_create("header_pool", NB_HDR_MBUF, - HDR_MBUF_SIZE, 32, 0, NULL, NULL, rte_pktmbuf_init, NULL, + HDR_MBUF_SIZE, 32, sizeof(struct rte_pktmbuf_pool_private), + rte_pktmbuf_pool_init, NULL, rte_pktmbuf_init, NULL, rte_socket_id(), 0); if (header_pool == NULL) rte_exit(EXIT_FAILURE, "Cannot init header mbuf pool\n"); clone_pool = rte_mempool_create("clone_pool", NB_CLONE_MBUF, - CLONE_MBUF_SIZE, 32, 0, NULL, NULL, rte_pktmbuf_init, NULL, + CLONE_MBUF_SIZE, 32, sizeof(struct rte_pktmbuf_pool_private), + rte_pktmbuf_pool_init, NULL, rte_pktmbuf_init, NULL, rte_socket_id(), 0); if (clone_pool == NULL) -- 2.1.4