From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E781A04B6; Mon, 12 Oct 2020 16:33:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 71C941D8CE; Mon, 12 Oct 2020 16:33:28 +0200 (CEST) Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 983A91C0DC for ; Mon, 12 Oct 2020 16:33:27 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.nyi.internal (Postfix) with ESMTP id 09C305802E0; Mon, 12 Oct 2020 10:33:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 12 Oct 2020 10:33:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= oERj0nz9axuR4Ltww2OjQMt6yL3TlsTf+bXFnA5muPM=; b=gw8xUK646xcJ6+zo flERLBB12xpMAAvt7JeXiyyN+egrp8/z8icMh23p5dDHGSUEtRWh0v6o3ZeIfTAv 6YZKlBFTtygZhTit2Xd8H45/efLjwrxvVEDAH07eMZOhn9vhRd4F7sntMZKWZl0l uyKkN+ckyf5zL+Xq7f6ToWFj3vQQGGDLyvFB0xSwFejTn4uITlPT8lbSsrMBRpjk mCaS2V0DlD4/aMgcvKZaHwZYqHbFLhf69KnCVT26drikkAvx4Cl93fME1yyLeJ2L NKs1mM8vnnWeWy7YLRVvVN94pYMurC4Q7GXpQr54wfwwEMQTfQ/3ZjkGtqNG+9AR bcjnBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=oERj0nz9axuR4Ltww2OjQMt6yL3TlsTf+bXFnA5mu PM=; b=gIwZ0oiZWFBDgWOKOiqIdTR3zMPxBeaCHVivQObKXURJf/X6UWG3AZVlw 0vFodaJQJR04kdCYAF+KO/rAkbGb+Qm6Aybf5V8Q4AMbpYom21S07Dj1Ft+YaLEc 79G/DBHVgCLzFgQDHcpkWvLTDCHW96McaOjm9HbFLg1Ha+uK1FrbE86EQ5W4GYJS V9+RZme8vua/CVowNiJawgWtfqGqNvxl5aLcgQbdtjDQI4sLwnJZ8I0UvdfYAtPW ShGt9Ur3kYciiS+mOOQDXvwvezq5yjJys2nZTDCZ9WR/X7nGTXe2aOiqmfJKfrM/ GkIASPgvxkje7J3U8xlXz+EBOHqMA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrheejgdejkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgjfhgggfgtsehtufertd dttddvnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm ohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepudeggfdvfeduffdtfeegle fghfeukefgfffhueejtdetuedtjeeuieeivdffgeehnecukfhppeejjedrudefgedrvddt fedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E6DA93280063; Mon, 12 Oct 2020 10:33:21 -0400 (EDT) From: Thomas Monjalon To: guyk@marvell.com Cc: orika@mellanox.com, jerinj@marvell.com, ndabilpuram@marvell.com, mdr@ashroe.eu, nhorman@tuxdriver.com, bruce.richardson@intel.com, anatoly.burakov@intel.com, john.mcnamara@intel.com, marko.kovacevic@intel.com, dev@dpdk.org, smadarf@marvell.com, dovrat@marvell.com, lironh@marvell.com Date: Mon, 12 Oct 2020 16:33:20 +0200 Message-ID: <14309339.Y1dYQgYOla@thomas> In-Reply-To: <20201012113135.19476-3-guyk@marvell.com> References: <20200901122436.17748-1-guyk@marvell.com> <20201012113135.19476-1-guyk@marvell.com> <20201012113135.19476-3-guyk@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 2/4] regex/octeontx2: add build infra and device support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 12/10/2020 13:31, guyk@marvell.com: > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1118,6 +1118,9 @@ F: drivers/regex/mlx5/ > F: doc/guides/regexdevs/mlx5.rst > F: doc/guides/regexdevs/features/mlx5.ini > > +Marvell OCTEON TX2 regex > +M: Guy Kaneti > +F: drivers/regex/octeontx2/ > A blank line is missing. Please sort in alphabetical order. > --- /dev/null > +++ b/drivers/regex/octeontx2/rte_pmd_octeontx2_regex_version.map > @@ -0,0 +1,3 @@ > +DPDK_20.08 { > + local: *; > +}; Should be DPDK_21 > --- a/meson_options.txt > +++ b/meson_options.txt > +option('ree_compiler_sdk', type: 'string', value: '', > + description: 'path to REE compiler SDK optional library for regex device') Is this SDK specific to Marvell or octeontx2? If yes, it should appear here. Why this SDK requires setting the path manually? Well designed libs should use pkg-config.