From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f174.google.com (mail-pd0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 1244C5A3E for ; Fri, 15 May 2015 19:08:30 +0200 (CEST) Received: by pdfh10 with SMTP id h10so18141043pdf.3 for ; Fri, 15 May 2015 10:08:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=aMUiWIi3EzOF4/o4TxFBsY7wDquXpzUZar6nG99y4Z0=; b=bgWWeCJqIjZ2R1XwWn/BL3gBC39baqYfim0E1s6s8GCtM3yIl4joi0zJgRVgXcmdi+ 6V19kE8no5WuvxtwH1/C6O1j8NimDMZEW1CAXddSVwPWD4lqg4Pj5P3YErqNzleKxdM6 8KJZ7YoABgtYNd3YUkBlY2MSuOkjSPdtwNUTVBIAJ07rprs5iCjlQp+oSvR3hwF4478G nni5aDF7tHL8jBKjSM8I2gdLfRVdgPdZPBM9TVlkju1H72irPqv4nLK5053NGd1l59Ls X7vRrsc1/CO2q8b7EJKe+noTggLNbfW557JxBWcW5/cSUQG9Fy16sB+wfrlQZ2BkSX4M +qeQ== X-Gm-Message-State: ALoCoQlqSKu7CqEqrAO0cgMWdvobzPQbNeyJVhi3aXfgocFeQKTZINCaP4v/3fLecBKeh3HRI16s X-Received: by 10.66.142.42 with SMTP id rt10mr19842431pab.142.1431709709509; Fri, 15 May 2015 10:08:29 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id sc1sm2415592pac.36.2015.05.15.10.08.28 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 May 2015 10:08:28 -0700 (PDT) From: Stephen Hemminger To: helin.zhang@intel.com Date: Fri, 15 May 2015 10:08:25 -0700 Message-Id: <1431709707-5281-4-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431709707-5281-1-git-send-email-stephen@networkplumber.org> References: <1431709707-5281-1-git-send-email-stephen@networkplumber.org> Cc: dev@dpdk.org Subject: [dpdk-dev] [PATCH 3/5] ixgbe: raise priority of significant events X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2015 17:08:30 -0000 The driver does lots of logging at INFO level, but some setup events are significant and should be at NOTICE or ERR level since they are problems that user should see. Also never put tabs in log messages because they get mangled by syslog processing. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c index fa335f4..7e75382 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c +++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c @@ -1054,8 +1054,8 @@ eth_ixgbevf_dev_init(struct rte_eth_dev *eth_dev) eth_dev->data->mac_addrs = NULL; return diag; } - PMD_INIT_LOG(INFO, "\tVF MAC address not assigned by Host PF"); - PMD_INIT_LOG(INFO, "\tAssign randomly generated MAC address " + PMD_INIT_LOG(NOTICE, "VF MAC address not assigned by Host PF"); + PMD_INIT_LOG(NOTICE, "Assign randomly generated MAC address " "%02x:%02x:%02x:%02x:%02x:%02x", perm_addr->addr_bytes[0], perm_addr->addr_bytes[1], @@ -1248,7 +1248,7 @@ ixgbe_vlan_hw_strip_disable(struct rte_eth_dev *dev, uint16_t queue) if (hw->mac.type == ixgbe_mac_82598EB) { /* No queue level support */ - PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip"); + PMD_INIT_LOG(ERR, "82598EB not support queue level hw strip"); return; } else { @@ -1272,7 +1272,7 @@ ixgbe_vlan_hw_strip_enable(struct rte_eth_dev *dev, uint16_t queue) if (hw->mac.type == ixgbe_mac_82598EB) { /* No queue level supported */ - PMD_INIT_LOG(INFO, "82598EB not support queue level hw strip"); + PMD_INIT_LOG(ERR, "82598EB not support queue level hw strip"); return; } else { @@ -2951,12 +2951,12 @@ ixgbevf_dev_configure(struct rte_eth_dev *dev) */ #ifndef RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC if (!conf->rxmode.hw_strip_crc) { - PMD_INIT_LOG(INFO, "VF can't disable HW CRC Strip"); + PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip"); conf->rxmode.hw_strip_crc = 1; } #else if (conf->rxmode.hw_strip_crc) { - PMD_INIT_LOG(INFO, "VF can't enable HW CRC Strip"); + PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip"); conf->rxmode.hw_strip_crc = 0; } #endif -- 2.1.4