From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id BA6A9678C for ; Wed, 28 May 2014 01:09:39 +0200 (CEST) Received: by mail-wg0-f43.google.com with SMTP id l18so10021746wgh.26 for ; Tue, 27 May 2014 16:09:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=zG7qQvuO6Ew+AGdUjkjnSXau2zh+d5chKJzVaw/aOiM=; b=ImoIyE8ML9yJjz+G3hTWHfRYzNbgjUNKQvz/oavnSlgR621lWrHmezFMCpV2ZSsmcR lyJU+jN4y3+1+KNQalbKDEQO8C44kUFBZUk75S2cfypIjk2IQ71nFfkhJUBazfGM0gH9 YOIVh3tV0mUtEpKbkn4on2rz3xu+6cGmW8MBsH0kOYDtzJwGAejVRdIu0Uwi47QCcrh4 SrjoUPoB2oUddfYWgOGfteuXDU/5jUZrDo0MZx9j34jjQ4pTrfpWci4OByZddi4fF5fR iCAvKWxwNKqvG2BzBMkRbbfM96n2xVdrOUVCnXD30Z4ht3z/yCsW3I3D5jKNPVNpYcXt DHFQ== X-Gm-Message-State: ALoCoQl0GLxOGq918j+cpqZBplckEAj6azroWKoAXO2oB39Ve1TNbFn/x9i40TOLCrWmzJ9jlFH9 X-Received: by 10.180.84.226 with SMTP id c2mr43028038wiz.50.1401232190509; Tue, 27 May 2014 16:09:50 -0700 (PDT) Received: from xps13.localnet (ip-96.net-80-236-123.rev.numericable.fr. [80.236.123.96]) by mx.google.com with ESMTPSA id fh5sm6973582wic.9.2014.05.27.16.09.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 May 2014 16:09:49 -0700 (PDT) From: Thomas Monjalon To: Vladimir Medvedkin Date: Wed, 28 May 2014 01:09:47 +0200 Message-ID: <1431824.kSt8MFELsZ@xps13> Organization: 6WIND User-Agent: KMail/4.13 (Linux/3.14.4-1-ARCH; KDE/4.13.0; x86_64; ; ) In-Reply-To: <1400543506-24717-1-git-send-email-medvedkinv@gmail.com> References: <1400543506-24717-1-git-send-email-medvedkinv@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/3] ixgbe: Add L2 Ethertype, SYN and Five tuple queue filters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2014 23:09:40 -0000 Hi Vladimir, Seems like hardware filtering becomes useful these days :) 2014-05-19 19:51, Vladimir Medvedkin: > This patchset adds in addition to the Flow Director filters L2 Ethertype, > SYN and Five tuple queue filters to route packets according to ethertype, > l4 proto, source/destination ip/ports pool and presence of SYN flag in TCP > packet. Unlike http://dpdk.org/ml/archives/dev/2014-May/002512.html this > gives capability to work with pools. This patch functionality can be merged > with the patch above. 2 comments: 1) Do you have a good confidence that this new API is generic enough to be used by other NICs than ixgbe? 2) Could you try to check your patches with the kernel script checkpatch.pl, please? Thanks -- Thomas