From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f52.google.com (mail-pa0-f52.google.com [209.85.220.52]) by dpdk.org (Postfix) with ESMTP id 174BB9A9E for ; Tue, 19 May 2015 07:55:23 +0200 (CEST) Received: by padbw4 with SMTP id bw4so8967238pad.0 for ; Mon, 18 May 2015 22:55:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=EAmXUFoW7uiMnOQFFoGxU3hvJyLmQ3UZ2kzRoNPuoqI=; b=SS3vCCWV/djGO5Ix+pM5p1ZsRg6Vk5m/OLd5Src/VdV2jbtFR5CMkHqa0Jde401TUv X9v5wlrAZQQqUprnmCU1a7FakHOEEghNH4na1wJOIjEhfiCV8RmSCBoku+7RXtDYrC1/ L/Y6Y1pKMtFJ4ZVcXDBPxCig3Q9WV8QlRBplqTR+QMktBxkhSu/jc9BNp4nGkd5tdP2Z vVvx32E7W9L/WAjW75rckdAS8fUSB9JstsBAqnupPGISeo/DNH27WzAByZAqexqQI6Ul P9Atv0nILzooGtetslvkGukeswI0wdrCU/9NQc0ELHl1lSJHEaWUSzsJ2Lkn9ERmVguZ uCLQ== X-Gm-Message-State: ALoCoQlt6muZgH6kmytw+r9ETEICFrF32J9IIOAsC4sD+a1UCNSfTsgAH+M/y6dSay07Wv3Yb7Z6 X-Received: by 10.70.108.137 with SMTP id hk9mr50583158pdb.105.1432014922350; Mon, 18 May 2015 22:55:22 -0700 (PDT) Received: from localhost.localdomain (napt.igel.co.jp. [219.106.231.132]) by mx.google.com with ESMTPSA id qz7sm11796528pbc.11.2015.05.18.22.55.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 18 May 2015 22:55:21 -0700 (PDT) From: Tetsuya Mukawa To: dev@dpdk.org Date: Tue, 19 May 2015 14:54:53 +0900 Message-Id: <1432014898-3543-1-git-send-email-mukawa@igel.co.jp> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH v4 0/5] Clean up pci uio implementations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 05:55:23 -0000 This patch set cleans up pci uio implementation. These clean up are for consolidating pci uio implementation of linuxapp and bsdapp, and moving consolidated functions in eal common. Because of above, this patch set tries to implement linuxapp and bsdapp almost same. Actual consolidations will be done later patch set. PATCH v4 changes: - Rebase to latest master branch. - Fix bug in pci_uio_map_resource() of BSD code. 'maps[i].path' shouldn't be freed. Fixed in below patch: [PATCH 3/5] eal: Fix memory leaks and needless increment of pci_map_addr - 'path' member of 'struct mapped_pci_resource' should not be removed because it will be used in BSD code. Fixed in below patch: [PATCH 5/5] eal: Fix uio mapping differences between linuxapp and bsdapp PATCH v3 changes: - Squash patches related with pci_map_resource(). - Free maps[].path to easy to understand. (Thanks to Iremonger, Bernard) - Close fds opened in this function. - Remove unused path variable from mapped_pci_resource structure. PATCH v2 changes: - Move 'if-condition' to later patch series. - Fix memory leaks of path. - Fix typos. (Thanks to David Marchand) - Fix commit title and body. - Fix pci_map_resource() to handle MAP_FAILED. (Thanks to Iremonger, Bernard) Changes: - This patch set is derived from below. "[PATCH v2] eal: Port Hotplug support for BSD" - Set cfg_fd as -1, when cfg_fd is closed. (Thanks to Iremonger, Bernard) - Remove needless coding style fixings. - Fix coding style of if-else condition. (Thanks to Richardson, Bruce) Tetsuya Mukawa (5): eal: Fix coding style of eal_pci.c and eal_pci_uio.c eal: Close file descriptor of uio configuration eal: Fix memory leaks and needless increment of pci_map_addr eal/bsdapp: Change names of pci related data structure eal: Fix uio mapping differences between linuxapp and bsdapp lib/librte_eal/bsdapp/eal/eal_pci.c | 164 ++++++++++++++++++------------ lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 88 +++++++++------- 2 files changed, 153 insertions(+), 99 deletions(-) -- 2.1.4