DPDK patches and discussions
 help / color / mirror / Atom feed
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] app/testpmd: compute checksum in icmpecho replies
Date: Fri, 22 May 2015 19:03:12 +0200	[thread overview]
Message-ID: <1432314192-17828-1-git-send-email-adrien.mazarguil@6wind.com> (raw)
In-Reply-To: <1432292852-15701-2-git-send-email-adrien.mazarguil@6wind.com>

ICMP echo replies with invalid checksums may be dropped by network nodes or
ignored by the ping utility.

Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Acked-by: Ivan Boule <ivan.boule@6wind.com>
---

v2:
- Compute correct checksum value by taking overflow into account.

 app/test-pmd/icmpecho.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/icmpecho.c b/app/test-pmd/icmpecho.c
index c5933f4..e249e71 100644
--- a/app/test-pmd/icmpecho.c
+++ b/app/test-pmd/icmpecho.c
@@ -295,6 +295,7 @@ reply_to_icmp_echo_rqsts(struct fwd_stream *fs)
 	uint16_t vlan_id;
 	uint16_t arp_op;
 	uint16_t arp_pro;
+	uint32_t cksum;
 	uint8_t  i;
 	int l2_len;
 #ifdef RTE_TEST_PMD_RECORD_CORE_CYCLES
@@ -445,7 +446,8 @@ reply_to_icmp_echo_rqsts(struct fwd_stream *fs)
 		 * - switch IPv4 source and destinations addresses,
 		 * - set IP_ICMP_ECHO_REPLY in ICMP header.
 		 * No need to re-compute the IP header checksum.
-		 * Reset ICMP checksum.
+		 * ICMP checksum is computed by assuming it is valid in the
+		 * echo request and not verified.
 		 */
 		ether_addr_copy(&eth_h->s_addr, &eth_addr);
 		ether_addr_copy(&eth_h->d_addr, &eth_h->s_addr);
@@ -454,7 +456,12 @@ reply_to_icmp_echo_rqsts(struct fwd_stream *fs)
 		ip_h->src_addr = ip_h->dst_addr;
 		ip_h->dst_addr = ip_addr;
 		icmp_h->icmp_type = IP_ICMP_ECHO_REPLY;
-		icmp_h->icmp_cksum = 0;
+		cksum = ~icmp_h->icmp_cksum & 0xffff;
+		cksum += ~htons(IP_ICMP_ECHO_REQUEST << 8) & 0xffff;
+		cksum += htons(IP_ICMP_ECHO_REPLY << 8);
+		cksum = (cksum & 0xffff) + (cksum >> 16);
+		cksum = (cksum & 0xffff) + (cksum >> 16);
+		icmp_h->icmp_cksum = ~cksum;
 		pkts_burst[nb_replies++] = pkt;
 	}
 
-- 
2.1.0

  parent reply	other threads:[~2015-05-22 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-22 11:07 [dpdk-dev] [PATCH 1/2] app/testpmd: use correct hardware address in ARP replies Adrien Mazarguil
2015-05-22 11:07 ` [dpdk-dev] [PATCH 2/2] app/testpmd: compute checksum in icmpecho replies Adrien Mazarguil
2015-05-22 12:42   ` Olivier MATZ
2015-05-22 13:34     ` Adrien Mazarguil
2015-05-22 17:03   ` Adrien Mazarguil [this message]
     [not found]     ` <55630A3E.5080708@6wind.com>
2015-05-29 16:12       ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2015-05-29 16:11 ` [dpdk-dev] [PATCH 1/2] app/testpmd: use correct hardware address in ARP replies Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432314192-17828-1-git-send-email-adrien.mazarguil@6wind.com \
    --to=adrien.mazarguil@6wind.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).