From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id 8BC6D6A80 for ; Thu, 16 Apr 2015 11:03:15 +0200 (CEST) Received: by widdi4 with SMTP id di4so89353264wid.0 for ; Thu, 16 Apr 2015 02:03:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=DiL0q3dhIBIHOh9DGFtyBQVXlVsI5VhXoNaADRx1Xj8=; b=KyPq3rb0b+tQFDMxEjC38+YFvCqcstxhm+m+QDXnZJySv8PN1eQclF1jd8GEOZzVBU xwYZuc/QVv0ouAHDGHG9J7kK1SfxbAEuXP6bB8FtOClxHnn2viAe0D4i6NdmG9r9/h2F 6bkm/sTgqRmXIr1LmeA4VS5R259rnUzOfXv8A4AtzHgnc5Szhb1OYTtHeuN7afNbIejM 37BaQaxGKMI018Idzx4tF4ttvV/DVt+USb2dDvL3bysqgwgrTR7XDj//sdEL3HwxuiYq +/sASI1aEW+Mpimf7WrWAIY3Uds3lB9AHCuMCvDQlRlVvJdNeh2Z9Eyx872PaiI2LwER iBzg== X-Gm-Message-State: ALoCoQmuvj8FYuX0WUNCJk70mYf48PuM8OaMPaEU919BD79U5i8qQLTz/HKhLGan3Zv9Gw++ze52 X-Received: by 10.180.106.73 with SMTP id gs9mr2270546wib.52.1429174995472; Thu, 16 Apr 2015 02:03:15 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id z12sm9459466wjq.12.2015.04.16.02.03.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Apr 2015 02:03:14 -0700 (PDT) From: Thomas Monjalon To: Ravi Kerur Date: Thu, 16 Apr 2015 11:02:31 +0200 Message-ID: <1432996.oUgD5RRFGj@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1428608412-31191-7-git-send-email-rkerur@gmail.com> References: <1428608301-31033-1-git-send-email-rkerur@gmail.com> <1428608412-31191-1-git-send-email-rkerur@gmail.com> <1428608412-31191-7-git-send-email-rkerur@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v5 6/8] Move common functions in eal_pci.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2015 09:03:15 -0000 This patch is very sensible and difficult to follow. I'm really afraid that some nasty bugs could be hidden. Please could you try to split it in several steps? Thanks 2015-04-09 12:40, Ravi Kerur: > Changes in v5 > Rebase to latest code. > Removed RTE_EXEC_ENV_BSDAPP from earlier changes. > > Changes in v4 > Move common functions in eal_pci.c to librte_eal/common/ > eal_common_pci.c file. > > Following functions are moved to eal_common_pci.c file. > > void *pci_map_resource(void *requested_addr, const int vfio_fd, > const char *devname, off_t offset, size_t size); > int pci_addr_comparison(struct rte_pci_addr *addr, > struct rte_pci_addr *addr2); > int rte_eal_pci_probe_one_driver(struct rte_pci_driver *dr, > struct rte_pci_device *dev); > > Use RTE_EXEC_ENV_BSDAPP to differentiate minor differences in > common function. > Fix checkpatch warnings and errors. > > Changes in v3 > N/A > > Changes in v2 > N/A > > Changes in v1 > N/A > > Signed-off-by: Ravi Kerur > --- > lib/librte_eal/bsdapp/eal/eal_pci.c | 122 ++++----------------------- > lib/librte_eal/common/eal_common_pci.c | 130 ++++++++++++++++++++++++++++- > lib/librte_eal/common/eal_private.h | 48 +++++++++++ > lib/librte_eal/linuxapp/eal/eal_pci.c | 100 +--------------------- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 6 -- > lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 36 ++------ > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 17 ++-- > 7 files changed, 212 insertions(+), 247 deletions(-)