* [dpdk-dev] [PATCH] app/testpmd: fix default RX/TX flow control values
@ 2015-06-01 12:11 David Marchand
2015-06-15 9:53 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2015-06-01 12:11 UTC (permalink / raw)
To: dev; +Cc: Ding Zhi
From: Ding Zhi <zhi.ding@6wind.com>
This variable has undefined values in some cases.
Fixes: 422a20a4e62d ("app/testpmd: fix uninitialized flow control variables")
Signed-off-by: Ding Zhi <zhi.ding@6wind.com>
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index f01db2a..aec7a0b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -4743,7 +4743,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,
struct cmd_link_flow_ctrl_set_result *res = parsed_result;
cmdline_parse_inst_t *cmd = data;
struct rte_eth_fc_conf fc_conf;
- int rx_fc_en, tx_fc_en = 0;
+ int rx_fc_en = 0, tx_fc_en = 0;
int ret;
/*
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix default RX/TX flow control values
2015-06-01 12:11 [dpdk-dev] [PATCH] app/testpmd: fix default RX/TX flow control values David Marchand
@ 2015-06-15 9:53 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2015-06-15 9:53 UTC (permalink / raw)
To: David Marchand, Ding Zhi; +Cc: dev
> This variable has undefined values in some cases.
>
> Fixes: 422a20a4e62d ("app/testpmd: fix uninitialized flow control variables")
> Signed-off-by: Ding Zhi <zhi.ding@6wind.com>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4743,7 +4743,7 @@ cmd_link_flow_ctrl_set_parsed(void *parsed_result,
> struct cmd_link_flow_ctrl_set_result *res = parsed_result;
> cmdline_parse_inst_t *cmd = data;
> struct rte_eth_fc_conf fc_conf;
> - int rx_fc_en, tx_fc_en = 0;
> + int rx_fc_en = 0, tx_fc_en = 0;
> int ret;
Applied with lines split to conform with the coding rules:
http://dpdk.org/browse/dpdk/tree/doc/guides/guidelines/coding_style.rst#n461
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-06-15 9:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-01 12:11 [dpdk-dev] [PATCH] app/testpmd: fix default RX/TX flow control values David Marchand
2015-06-15 9:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).