From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by dpdk.org (Postfix) with ESMTP id 2FD88C31C for ; Wed, 3 Jun 2015 21:19:28 +0200 (CEST) Received: by obcnx10 with SMTP id nx10so15923461obc.2 for ; Wed, 03 Jun 2015 12:19:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WppOcdz3VCwVce1zqOAJ4pyVp+DT35hZakw8491hUXc=; b=WRf1pdJTS4GD0glf8fBa4VDH4iqxpZBwFKs4HRdhDPhiwdkzVuqORryxd3l/p2SqdQ BFt8WuI+6Dhc5OpwYFPACLhL7D5VpMjDKq76XcM6vXYXQgD1AvzLYJUKCa6f14IwfrdM sbgyRjejQPzAP4SQ8tmmRJ8yXmczBzfnkiDOSylv6k96ov4UwH/lt8lI+JtGmwySqclD v0so1cXzFIRihRgvvogSaqo1vE0+dRP98+5B5742snuYAyqj/YqhpLes1HekkAvqj24Q uAsvcIiiz3fMakXf8MkFn+s3rJl4/5pr9FJrXaYIRKTdS541H/ECtagYLodiEGIhGeVm kJfQ== X-Gm-Message-State: ALoCoQlciF6GSuyjqVqQVnehW+6yYoJg5CIuu9C6vtOG6qmFOfTPuzJ3pWSbwoKfj1RN9TRaa4DI X-Received: by 10.202.87.133 with SMTP id l127mr27191009oib.83.1433359167679; Wed, 03 Jun 2015 12:19:27 -0700 (PDT) Received: from localhost.localdomain (rrcs-97-77-120-78.sw.biz.rr.com. [97.77.120.78]) by mx.google.com with ESMTPSA id c9sm12039646oih.11.2015.06.03.12.19.25 (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Jun 2015 12:19:26 -0700 (PDT) From: Jay Rolette To: dev@dpdk.org Date: Wed, 3 Jun 2015 14:18:55 -0500 Message-Id: <1433359137-12720-1-git-send-email-rolette@infiniteio.com> X-Mailer: git-send-email 2.3.2 (Apple Git-55) Subject: [dpdk-dev] [PATCH 1/3] kni: minor opto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Jun 2015 19:19:28 -0000 Don't need the 'safe' version of list_for_each_entry() if you aren't deleting from the list as you iterate over it Signed-off-by: Jay Rolette --- lib/librte_eal/linuxapp/kni/kni_misc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/kni_misc.c b/lib/librte_eal/linuxapp/kni/kni_misc.c index 1935d32..312f196 100644 --- a/lib/librte_eal/linuxapp/kni/kni_misc.c +++ b/lib/librte_eal/linuxapp/kni/kni_misc.c @@ -213,13 +213,12 @@ static int kni_thread_single(void *unused) { int j; - struct kni_dev *dev, *n; + struct kni_dev *dev; while (!kthread_should_stop()) { down_read(&kni_list_lock); for (j = 0; j < KNI_RX_LOOP_NUM; j++) { - list_for_each_entry_safe(dev, n, - &kni_list_head, list) { + list_for_each_entry(dev, &kni_list_head, list) { #ifdef RTE_KNI_VHOST kni_chk_vhost_rx(dev); #else -- 2.3.2 (Apple Git-55)