DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jay Rolette <rolette@infiniteio.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH 3/3] kni: rx loop was using the wrong counter
Date: Wed,  3 Jun 2015 14:18:57 -0500	[thread overview]
Message-ID: <1433359137-12720-3-git-send-email-rolette@infiniteio.com> (raw)
In-Reply-To: <1433359137-12720-1-git-send-email-rolette@infiniteio.com>

Loop processing packets dequeued from rx_q was using the number of
packets requested, not how many it actually received.

Variable rename to make code a little more clear

Signed-off-by: Jay Rolette <rolette@infiniteio.com>
---
 lib/librte_eal/linuxapp/kni/kni_net.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c b/lib/librte_eal/linuxapp/kni/kni_net.c
index 13ccbb8..d37a6b9 100644
--- a/lib/librte_eal/linuxapp/kni/kni_net.c
+++ b/lib/librte_eal/linuxapp/kni/kni_net.c
@@ -131,7 +131,7 @@ kni_net_rx_normal(struct kni_dev *kni)
 {
 	unsigned ret;
 	uint32_t len;
-	unsigned i, num, num_fq;
+	unsigned i, num_rx, num_fq;
 	struct rte_kni_mbuf *kva;
 	struct rte_kni_mbuf *va[MBUF_BURST_SZ];
 	void * data_kva;
@@ -146,15 +146,15 @@ kni_net_rx_normal(struct kni_dev *kni)
 	}
 
 	/* Calculate the number of entries to dequeue from rx_q */
-	num = min(num_fq, (unsigned)MBUF_BURST_SZ);
+	num_rx = min(num_fq, (unsigned)MBUF_BURST_SZ);
 
 	/* Burst dequeue from rx_q */
-	ret = kni_fifo_get(kni->rx_q, (void **)va, num);
-	if (ret == 0)
+	num_rx = kni_fifo_get(kni->rx_q, (void **)va, num_rx);
+	if (num_rx == 0)
 		return;
 
 	/* Transfer received packets to netif */
-	for (i = 0; i < num; i++) {
+	for (i = 0; i < num_rx; i++) {
 		kva = (void *)va[i] - kni->mbuf_va + kni->mbuf_kva;
 		len = kva->data_len;
 		data_kva = kva->buf_addr + kva->data_off - kni->mbuf_va
@@ -184,8 +184,8 @@ kni_net_rx_normal(struct kni_dev *kni)
 	}
 
 	/* Burst enqueue mbufs into free_q */
-	ret = kni_fifo_put(kni->free_q, (void **)va, num);
-	if (ret != num)
+	ret = kni_fifo_put(kni->free_q, (void **)va, num_rx);
+	if (ret != num_rx)
 		/* Failing should not happen */
 		KNI_ERR("Fail to enqueue entries into free_q\n");
 }
-- 
2.3.2 (Apple Git-55)

  parent reply	other threads:[~2015-06-03 19:19 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-03 19:18 [dpdk-dev] [PATCH 1/3] kni: minor opto Jay Rolette
2015-06-03 19:18 ` [dpdk-dev] [PATCH 2/3] " Jay Rolette
2015-06-04 13:44   ` Bruce Richardson
2015-06-15  2:21   ` Zhang, Helin
2015-06-03 19:18 ` Jay Rolette [this message]
2015-06-04 13:47   ` [dpdk-dev] [PATCH 3/3] kni: rx loop was using the wrong counter Bruce Richardson
2015-06-04 13:39 ` [dpdk-dev] [PATCH 1/3] kni: minor opto Bruce Richardson
2015-06-04 13:40   ` Bruce Richardson
2015-06-04 15:02     ` Thomas Monjalon
2015-06-04 15:05       ` Bruce Richardson
2015-06-15  2:07 ` Zhang, Helin
2015-06-15 12:42   ` Jay Rolette
2015-06-16  1:15     ` Zhang, Helin
2015-06-16 15:20       ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2015-06-03 19:07 Jay Rolette
2015-06-03 19:07 ` [dpdk-dev] [PATCH 3/3] kni: rx loop was using the wrong counter Jay Rolette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433359137-12720-3-git-send-email-rolette@infiniteio.com \
    --to=rolette@infiniteio.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).