DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maryam Tahhan <maryam.tahhan@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 4/7] ethdev: expose extended error stats
Date: Tue,  9 Jun 2015 16:10:43 +0100	[thread overview]
Message-ID: <1433862646-91880-5-git-send-email-maryam.tahhan@intel.com> (raw)
In-Reply-To: <1433862646-91880-1-git-send-email-maryam.tahhan@intel.com>

Extend rte_eth_xstats_get to retrieve additional stats from the device
driver as well the top level extended stats.

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
---
 lib/librte_ether/rte_ethdev.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c
index a439b4a..ce163a1 100644
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -1745,7 +1745,7 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,
 {
 	struct rte_eth_stats eth_stats;
 	struct rte_eth_dev *dev;
-	unsigned count, i, q;
+	unsigned count = 0, xcount = 0, i, q;
 	uint64_t val;
 	char *stats_ptr;
 
@@ -1758,18 +1758,19 @@ rte_eth_xstats_get(uint8_t port_id, struct rte_eth_xstats *xstats,
 
 	/* implemented by the driver */
 	if (dev->dev_ops->xstats_get != NULL)
-		return (*dev->dev_ops->xstats_get)(dev, xstats, n);
+		xcount = (*dev->dev_ops->xstats_get)(dev, xstats, n);
 
 	/* else, return generic statistics */
 	count = RTE_NB_STATS;
 	count += dev->data->nb_rx_queues * RTE_NB_RXQ_STATS;
 	count += dev->data->nb_tx_queues * RTE_NB_TXQ_STATS;
+	count += xcount;
 	if (n < count)
 		return count;
 
 	/* now fill the xstats structure */
 
-	count = 0;
+	count = xcount;
 	rte_eth_stats_get(port_id, &eth_stats);
 
 	/* global stats */
-- 
1.9.3

  parent reply	other threads:[~2015-06-09 15:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 15:10 [dpdk-dev] [PATCH v2 0/7] Expose IXGBE extended stats to DPDK apps Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 1/7] ethdev: add additional error stats Maryam Tahhan
2015-06-10  0:29   ` Stephen Hemminger
2015-06-17 14:01     ` Thomas Monjalon
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 2/7] ixgbe: move stats register reads to a new function Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 3/7] ixgbe: Expose extended error statistics Maryam Tahhan
2015-06-09 15:10 ` Maryam Tahhan [this message]
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 5/7] testpmd: extend testpmd to show all extended stats Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 6/7] app: remove dump_cfg Maryam Tahhan
2015-06-09 15:10 ` [dpdk-dev] [PATCH v2 7/7] app: add a new app proc_info Maryam Tahhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433862646-91880-5-git-send-email-maryam.tahhan@intel.com \
    --to=maryam.tahhan@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).