DPDK patches and discussions
 help / color / mirror / Atom feed
From: Cyril Chemparathy <cchemparathy@ezchip.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2 08/10] librte_mbuf: Add rte_pktmbuf_mtod_offset()
Date: Fri, 19 Jun 2015 10:34:51 -0700	[thread overview]
Message-ID: <1434735293-15469-9-git-send-email-cchemparathy@ezchip.com> (raw)
In-Reply-To: <1434735293-15469-1-git-send-email-cchemparathy@ezchip.com>

There are a number of instances in the code where rte_pktmbuf_mtod()
is used to get the mbuf data pointer, only to add an offset before
casting the result to some other header type.  This patch adds a new
rte_pktmbuf_mtod_offset() macro to eliminate these awful double cast
situations.

Signed-off-by: Cyril Chemparathy <cchemparathy@ezchip.com>
---
 lib/librte_mbuf/rte_mbuf.h | 24 +++++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
index 6efd2b5..396963c 100644
--- a/lib/librte_mbuf/rte_mbuf.h
+++ b/lib/librte_mbuf/rte_mbuf.h
@@ -54,6 +54,7 @@
  */
 
 #include <stdint.h>
+#include <rte_common.h>
 #include <rte_mempool.h>
 #include <rte_memory.h>
 #include <rte_atomic.h>
@@ -1080,18 +1081,35 @@ static inline struct rte_mbuf *rte_pktmbuf_lastseg(struct rte_mbuf *m)
 }
 
 /**
+ * A macro that points to an offset into the data in the mbuf.
+ *
+ * The returned pointer is cast to type t. Before using this
+ * function, the user must ensure that the first segment is large
+ * enough to accomodate its data.
+ *
+ * @param m
+ *   The packet mbuf.
+ * @param o
+ *   The offset into the mbuf data.
+ * @param t
+ *   The type to cast the result into.
+ */
+#define rte_pktmbuf_mtod_offset(m, t, o)	\
+	((t)((char *)(m)->buf_addr + (m)->data_off + (o)))
+
+/**
  * A macro that points to the start of the data in the mbuf.
  *
  * The returned pointer is cast to type t. Before using this
- * function, the user must ensure that m_headlen(m) is large enough to
- * read its data.
+ * function, the user must ensure that the first segment is large
+ * enough to accomodate its data.
  *
  * @param m
  *   The packet mbuf.
  * @param t
  *   The type to cast the result into.
  */
-#define rte_pktmbuf_mtod(m, t) ((t)((char *)(m)->buf_addr + (m)->data_off))
+#define rte_pktmbuf_mtod(m, t) rte_pktmbuf_mtod_offset(m, t, 0)
 
 /**
  * A macro that returns the length of the packet.
-- 
2.1.2

  parent reply	other threads:[~2015-06-19 17:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 17:34 [dpdk-dev] [PATCH v2 00/10] Improve cast alignment for strict aligned machines Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 01/10] mempool: silence -Wcast-align on pointer arithmetic Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 02/10] mbuf: " Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 03/10] ethdev: " Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 04/10] hash: " Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 05/10] eal: add and use unaligned integer types Cyril Chemparathy
2015-06-22  9:36   ` Thomas Monjalon
2015-06-22 16:47     ` Cyril Chemparathy
2015-06-22 16:56       ` Thomas Monjalon
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 06/10] app/test-pmd: pack simple_gre_hdr Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 07/10] app/test: use struct ether_addr instead of a byte array cast Cyril Chemparathy
2015-06-22  1:56   ` Stephen Hemminger
2015-06-22 16:40     ` Cyril Chemparathy
2015-06-19 17:34 ` Cyril Chemparathy [this message]
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 09/10] librte_mbuf: Add transform for rte_pktmbuf_mtod_offset() Cyril Chemparathy
2015-06-19 17:34 ` [dpdk-dev] [PATCH v2 10/10] librte_mbuf: Apply mtod-offset.cocci transform Cyril Chemparathy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434735293-15469-9-git-send-email-cchemparathy@ezchip.com \
    --to=cchemparathy@ezchip.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).