DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] cfgfile: Fix for Reading Files on nfs filesystem.
@ 2015-06-24 16:15 Daniel Mrzyglod
  2015-06-24 16:23 ` Thomas Monjalon
  2015-06-26  8:25 ` Mrzyglod, DanielX T
  0 siblings, 2 replies; 3+ messages in thread
From: Daniel Mrzyglod @ 2015-06-24 16:15 UTC (permalink / raw)
  To: dev

The problem occure when we have config files on NFS filesystem.
Solution with minimal change to library is to add buffer for I/O operations.
Without buffering there is  3-10% of faulty Reading from NFS.

The problem seems to be only NFS filesystem.

Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
 lib/librte_cfgfile/rte_cfgfile.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index b81c273..6105e0c 100644
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -93,10 +93,13 @@ rte_cfgfile_load(const char *filename, int flags)
 	int curr_section = -1;
 	int curr_entry = -1;
 	char buffer[256];
+	char f_streambuff[BUFSIZ];
 	int lineno = 0;
 	struct rte_cfgfile *cfg = NULL;
+	memset(f_streambuff,'\0',BUFSIZ);
 
 	FILE *f = fopen(filename, "r");
+	setbuf( f, f_streambuff);
 	if (f == NULL)
 		return NULL;
 
-- 
2.1.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-26  8:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-24 16:15 [dpdk-dev] [PATCH] cfgfile: Fix for Reading Files on nfs filesystem Daniel Mrzyglod
2015-06-24 16:23 ` Thomas Monjalon
2015-06-26  8:25 ` Mrzyglod, DanielX T

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).