From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9D15BC3E0 for ; Mon, 29 Jun 2015 00:25:33 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 28 Jun 2015 15:25:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,695,1427785200"; d="scan'208";a="752126219" Received: from irvmail001.ir.intel.com ([163.33.26.43]) by fmsmga002.fm.intel.com with ESMTP; 28 Jun 2015 15:25:31 -0700 Received: from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com [10.237.217.46]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id t5SMPUjT030610; Sun, 28 Jun 2015 23:25:30 +0100 Received: from sivswdev02.ir.intel.com (localhost [127.0.0.1]) by sivswdev02.ir.intel.com with ESMTP id t5SMPUdW010173; Sun, 28 Jun 2015 23:25:30 +0100 Received: (from pdelarax@localhost) by sivswdev02.ir.intel.com with id t5SMPUNS010169; Sun, 28 Jun 2015 23:25:30 +0100 From: Pablo de Lara To: dev@dpdk.org Date: Sun, 28 Jun 2015 23:25:20 +0100 Message-Id: <1435530330-10132-2-git-send-email-pablo.de.lara.guarch@intel.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1435530330-10132-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1435269919-7007-1-git-send-email-pablo.de.lara.guarch@intel.com> <1435530330-10132-1-git-send-email-pablo.de.lara.guarch@intel.com> Subject: [dpdk-dev] [PATCH v3 01/11] eal: add const in prefetch functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Jun 2015 22:25:34 -0000 rte_prefetchX functions included volatile void *p as parameter, but the function does not modify it, so it should include the const keyword. Signed-off-by: Pablo de Lara Acked-by: Bruce Richardson --- lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h | 6 +++--- lib/librte_eal/common/include/arch/x86/rte_prefetch.h | 14 +++++++------- lib/librte_eal/common/include/generic/rte_prefetch.h | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h b/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h index 9df0d13..fea3be1 100644 --- a/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h +++ b/lib/librte_eal/common/include/arch/ppc_64/rte_prefetch.h @@ -39,17 +39,17 @@ extern "C" { #include "generic/rte_prefetch.h" -static inline void rte_prefetch0(volatile void *p) +static inline void rte_prefetch0(const volatile void *p) { asm volatile ("dcbt 0,%[p],1" : : [p] "r" (p)); } -static inline void rte_prefetch1(volatile void *p) +static inline void rte_prefetch1(const volatile void *p) { asm volatile ("dcbt 0,%[p],1" : : [p] "r" (p)); } -static inline void rte_prefetch2(volatile void *p) +static inline void rte_prefetch2(const volatile void *p) { asm volatile ("dcbt 0,%[p],1" : : [p] "r" (p)); } diff --git a/lib/librte_eal/common/include/arch/x86/rte_prefetch.h b/lib/librte_eal/common/include/arch/x86/rte_prefetch.h index ec2454d..8e6e02c 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_prefetch.h +++ b/lib/librte_eal/common/include/arch/x86/rte_prefetch.h @@ -1,7 +1,7 @@ /*- * BSD LICENSE * - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -40,19 +40,19 @@ extern "C" { #include "generic/rte_prefetch.h" -static inline void rte_prefetch0(volatile void *p) +static inline void rte_prefetch0(const volatile void *p) { - asm volatile ("prefetcht0 %[p]" : [p] "+m" (*(volatile char *)p)); + asm volatile ("prefetcht0 %[p]" : : [p] "m" (*(const volatile char *)p)); } -static inline void rte_prefetch1(volatile void *p) +static inline void rte_prefetch1(const volatile void *p) { - asm volatile ("prefetcht1 %[p]" : [p] "+m" (*(volatile char *)p)); + asm volatile ("prefetcht1 %[p]" : : [p] "m" (*(const volatile char *)p)); } -static inline void rte_prefetch2(volatile void *p) +static inline void rte_prefetch2(const volatile void *p) { - asm volatile ("prefetcht2 %[p]" : [p] "+m" (*(volatile char *)p)); + asm volatile ("prefetcht2 %[p]" : : [p] "m" (*(const volatile char *)p)); } #ifdef __cplusplus diff --git a/lib/librte_eal/common/include/generic/rte_prefetch.h b/lib/librte_eal/common/include/generic/rte_prefetch.h index 217f319..725715f 100644 --- a/lib/librte_eal/common/include/generic/rte_prefetch.h +++ b/lib/librte_eal/common/include/generic/rte_prefetch.h @@ -1,7 +1,7 @@ /*- * BSD LICENSE * - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. + * Copyright(c) 2010-2015 Intel Corporation. All rights reserved. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -51,14 +51,14 @@ * @param p * Address to prefetch */ -static inline void rte_prefetch0(volatile void *p); +static inline void rte_prefetch0(const volatile void *p); /** * Prefetch a cache line into all cache levels except the 0th cache level. * @param p * Address to prefetch */ -static inline void rte_prefetch1(volatile void *p); +static inline void rte_prefetch1(const volatile void *p); /** * Prefetch a cache line into all cache levels except the 0th and 1th cache @@ -66,6 +66,6 @@ static inline void rte_prefetch1(volatile void *p); * @param p * Address to prefetch */ -static inline void rte_prefetch2(volatile void *p); +static inline void rte_prefetch2(const volatile void *p); #endif /* _RTE_PREFETCH_H_ */ -- 2.4.2