From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 99E845A66 for ; Mon, 29 Jun 2015 16:21:40 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP; 29 Jun 2015 07:21:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,699,1427785200"; d="scan'208";a="755167181" Received: from unknown ([10.217.248.46]) by orsmga002.jf.intel.com with SMTP; 29 Jun 2015 07:21:37 -0700 Received: by (sSMTP sendmail emulation); Mon, 29 Jun 2015 16:20:27 +0200 From: Daniel Mrzyglod To: dev@dpdk.org Date: Mon, 29 Jun 2015 16:20:25 +0200 Message-Id: <1435587625-5096-1-git-send-email-danielx.t.mrzyglod@intel.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1435307833-7432-1-git-send-email-danielx.t.mrzyglod@intel.com> References: <1435307833-7432-1-git-send-email-danielx.t.mrzyglod@intel.com> Subject: [dpdk-dev] [PATCH v2] cfgfile: fix unitialised buffer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jun 2015 14:21:41 -0000 Nature of the problem was not initialised buffer[256], there were probability that operation system will provide previously used memory and on special condition there were probability that string operations will work on random data that could provide unexpected program behaviour. Signed-off-by: Daniel Mrzyglod --- lib/librte_cfgfile/rte_cfgfile.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c index b81c273..9c85e9f 100644 --- a/lib/librte_cfgfile/rte_cfgfile.c +++ b/lib/librte_cfgfile/rte_cfgfile.c @@ -96,7 +96,10 @@ rte_cfgfile_load(const char *filename, int flags) int lineno = 0; struct rte_cfgfile *cfg = NULL; + memset(buffer, '\0', sizeof(buffer)); + FILE *f = fopen(filename, "r"); + if (f == NULL) return NULL; -- 2.1.0