From: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer
Date: Mon, 29 Jun 2015 17:06:03 +0200 [thread overview]
Message-ID: <1435590363-4656-1-git-send-email-danielx.t.mrzyglod@intel.com> (raw)
In-Reply-To: <1435307833-7432-1-git-send-email-danielx.t.mrzyglod@intel.com>
Nature of the problem was not initialised buffer[256], there were probability
that operation system will provide previously used memory and on special condition
there were probability that string operations will work on random data that
could provide unexpected program behaviour.
Changes in v3:
-Simplify the initialization of buffer.
Changes in v2:
-Found the real nature of problem. Only buffer was not initilized.
Changes in v1:
-Add additional separate IO buffer and initialize both buffers.
Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
---
lib/librte_cfgfile/rte_cfgfile.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index b81c273..a677dad 100644
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -92,7 +92,7 @@ rte_cfgfile_load(const char *filename, int flags)
int allocated_entries = 0;
int curr_section = -1;
int curr_entry = -1;
- char buffer[256];
+ char buffer[256] = {0};
int lineno = 0;
struct rte_cfgfile *cfg = NULL;
--
2.1.0
next prev parent reply other threads:[~2015-06-29 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 8:37 [dpdk-dev] [PATCH] cfgfile: fix unitialised buffer and improve reading from nfs filesystem Daniel Mrzyglod
2015-06-26 14:05 ` Bruce Richardson
2015-06-29 14:20 ` [dpdk-dev] [PATCH v2] cfgfile: fix unitialised buffer Daniel Mrzyglod
2015-06-29 14:33 ` Bruce Richardson
2015-06-29 14:32 ` [dpdk-dev] [PATCH] cfgfile: fix unitialised buffer and improve reading from nfs filesystem Mrzyglod, DanielX T
2015-06-29 15:06 ` Daniel Mrzyglod [this message]
2015-06-29 19:47 ` [dpdk-dev] [PATCH v3] cfgfile: fix unitialised buffer Dumitrescu, Cristian
2015-07-01 21:36 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435590363-4656-1-git-send-email-danielx.t.mrzyglod@intel.com \
--to=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).