[dpdk-dev] [PATCH] test/mempool: decrease size of requested mempool

[dpdk-dev] [PATCH] test/mempool: decrease size of requested mempool

[Olivier Matz]

In test application, the default size of allocated mempool is calculated
as following:

  (RTE_MAX_LCORE * (RTE_MEMPOOL_CACHE_MAX_SIZE + max_kept_objects)) - 1

The objective is to ensure that all cores can fill their cache and keep
'max_kept_objects' at the same time. As RTE_MAX_LCORE is 128 and
RTE_MEMPOOL_CACHE_MAX_SIZE is 512 in the default configuration, it can
produce very large mempools (170 MB).

We can replace the number of core by a dynamic value, which drastically
reduces the amount of memory needed for this test (5 MB with 4 cores).

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 app/test/test_mempool.c      | 2 +-
 app/test/test_mempool_perf.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/app/test/test_mempool.c b/app/test/test_mempool.c
index 9eb0d5d..72f8fb6 100644
--- a/app/test/test_mempool.c
+++ b/app/test/test_mempool.c
@@ -75,7 +75,7 @@
 #define TIME_S 5
 #define MEMPOOL_ELT_SIZE 2048
 #define MAX_KEEP 128
-#define MEMPOOL_SIZE ((RTE_MAX_LCORE*(MAX_KEEP+RTE_MEMPOOL_CACHE_MAX_SIZE))-1)
+#define MEMPOOL_SIZE ((rte_lcore_count()*(MAX_KEEP+RTE_MEMPOOL_CACHE_MAX_SIZE))-1)
 
 static struct rte_mempool *mp;
 static struct rte_mempool *mp_cache, *mp_nocache;
diff --git a/app/test/test_mempool_perf.c b/app/test/test_mempool_perf.c
index 1f7539c..cdc02a0 100644
--- a/app/test/test_mempool_perf.c
+++ b/app/test/test_mempool_perf.c
@@ -94,7 +94,7 @@
 #define TIME_S 5
 #define MEMPOOL_ELT_SIZE 2048
 #define MAX_KEEP 128
-#define MEMPOOL_SIZE ((RTE_MAX_LCORE*(MAX_KEEP+RTE_MEMPOOL_CACHE_MAX_SIZE))-1)
+#define MEMPOOL_SIZE ((rte_lcore_count()*(MAX_KEEP+RTE_MEMPOOL_CACHE_MAX_SIZE))-1)
 
 static struct rte_mempool *mp;
 static struct rte_mempool *mp_cache, *mp_nocache;
-- 
2.1.4

Re: [dpdk-dev] [PATCH] test/mempool: decrease size of requested mempool

[Bruce Richardson]

On Thu, Jul 09, 2015 at 11:01:29AM +0200, Olivier Matz wrote:
> In test application, the default size of allocated mempool is calculated
> as following:
> 
>   (RTE_MAX_LCORE * (RTE_MEMPOOL_CACHE_MAX_SIZE + max_kept_objects)) - 1
> 
> The objective is to ensure that all cores can fill their cache and keep
> 'max_kept_objects' at the same time. As RTE_MAX_LCORE is 128 and
> RTE_MEMPOOL_CACHE_MAX_SIZE is 512 in the default configuration, it can
> produce very large mempools (170 MB).
> 
> We can replace the number of core by a dynamic value, which drastically
> reduces the amount of memory needed for this test (5 MB with 4 cores).
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [dpdk-dev] [PATCH] test/mempool: decrease size of requested mempool

[Thomas Monjalon]

2015-07-09 12:18, Bruce Richardson:
> On Thu, Jul 09, 2015 at 11:01:29AM +0200, Olivier Matz wrote:
> > In test application, the default size of allocated mempool is calculated
> > as following:
> > 
> >   (RTE_MAX_LCORE * (RTE_MEMPOOL_CACHE_MAX_SIZE + max_kept_objects)) - 1
> > 
> > The objective is to ensure that all cores can fill their cache and keep
> > 'max_kept_objects' at the same time. As RTE_MAX_LCORE is 128 and
> > RTE_MEMPOOL_CACHE_MAX_SIZE is 512 in the default configuration, it can
> > produce very large mempools (170 MB).
> > 
> > We can replace the number of core by a dynamic value, which drastically
> > reduces the amount of memory needed for this test (5 MB with 4 cores).
> > 
> > Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks